refactor: standardize logging on zap across all packages

Replace all fmt.Printf/Println and log.Printf/Fatal with structured
zap.Logger calls to eliminate inconsistent logging (anti-pattern #12).

- network/crypt_conn: inject logger via NewCryptConn, replace 6 fmt calls
- signserver/session: use existing s.logger for debug packet dumps
- entranceserver: use s.logger for inbound/outbound debug logging
- api/utils: accept logger param in verifyPath, replace fmt.Println
- api/endpoints: use s.logger for screenshot path diagnostics
- config: replace log.Fatal with error return in getOutboundIP4
- deltacomp: replace log.Printf with zap.L() global logger
This commit is contained in:
Houmgaor
2026-02-20 18:59:12 +01:00
parent e5133e5dcf
commit 06cb3afa57
15 changed files with 134 additions and 117 deletions

View File

@@ -72,7 +72,7 @@ func TestLoadConfigClientModeMapping(t *testing.T) {
// TestLoadConfigFeatureWeaponConstraint tests MinFeatureWeapons > MaxFeatureWeapons constraint
func TestLoadConfigFeatureWeaponConstraint(t *testing.T) {
tests := []struct {
name string
name string
minWeapons int
maxWeapons int
expected int
@@ -107,7 +107,11 @@ func TestLoadConfigDefaultHost(t *testing.T) {
// When Host is empty, it should be set to the outbound IP
if cfg.Host == "" {
// Simulate the logic: if empty, set to outbound IP
cfg.Host = getOutboundIP4().To4().String()
ip, err := getOutboundIP4()
if err != nil {
t.Fatalf("getOutboundIP4() error: %v", err)
}
cfg.Host = ip.To4().String()
if cfg.Host == "" {
t.Error("Host should be set to outbound IP, got empty string")
}
@@ -271,12 +275,12 @@ func TestEntranceServerConfig(t *testing.T) {
Port: 10000,
Entries: []EntranceServerInfo{
{
IP: "192.168.1.100",
Type: 1, // open
Season: 0, // green
Recommended: 1,
Name: "Main Server",
Description: "Main hunting server",
IP: "192.168.1.100",
Type: 1, // open
Season: 0, // green
Recommended: 1,
Name: "Main Server",
Description: "Main hunting server",
AllowedClientFlags: 8192,
Channels: []EntranceChannelInfo{
{Port: 10001, MaxPlayers: 4, CurrentPlayers: 2},
@@ -486,9 +490,9 @@ func BenchmarkConfigCreation(b *testing.B) {
b.ResetTimer()
for i := 0; i < b.N; i++ {
_ = &Config{
Host: "localhost",
Language: "en",
ClientMode: "ZZ",
Host: "localhost",
Language: "en",
ClientMode: "ZZ",
RealClientMode: ZZ,
}
}