Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-22 07:32:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor(mhfpacket): rename 15 Unk fields with identified meanings

Browse Source 
Replace unknown field names with descriptive names based on handler
logic analysis, switch dispatch patterns, DB query context, and
inline comments:

- ObjectHandleID, IsQuest, ItemIDCount, MaxCount, TokenLength,
  FormatVersion, LogoutType (high confidence from comments/constants)
- QueryType, DataType, MissionIndex, CheckOnly, RequestType,
  ExchangeType, TournamentID (confirmed by handler switch/if usage)

Also fix MsgSysLogout.Build calling ReadUint8 instead of WriteUint8.
This commit is contained in:
Houmgaor
2026-02-18 21:48:08 +01:00
parent 2bd5f98f32
commit 0d07a1f698
35 changed files with 104 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
network/mhfpacket/msg_batch_parse_test.go
View File

@@ -141,7 +141,7 @@ func TestBatchParseMultiField(t *testing.T) {
if err := pkt.Parse(bf, ctx); err != nil {
t.Fatal(err)
}
if pkt.AckHandle != 1 || pkt.DistType != 2 || pkt.Unk1 != 3 || pkt.Unk2 != 4 {
if pkt.AckHandle != 1 || pkt.DistType != 2 || pkt.Unk1 != 3 || pkt.MaxCount != 4 {
t.Error("field mismatch")
}
})
@@ -206,7 +206,7 @@ func TestBatchParseMultiField(t *testing.T) {
if err := pkt.Parse(bf, ctx); err != nil {
t.Fatal(err)
}
if pkt.AckHandle != 1 || pkt.Unk0 != 2 || pkt.WorldID != 3 || pkt.LandID != 4 || !pkt.Unk1 {
if pkt.AckHandle != 1 || pkt.Unk0 != 2 || pkt.WorldID != 3 || pkt.LandID != 4 || !pkt.CheckOnly {
t.Error("field mismatch")
}
})
@@ -316,7 +316,7 @@ func TestBatchParseMultiField(t *testing.T) {
if err := pkt.Parse(bf, ctx); err != nil {
t.Fatal(err)
}
if pkt.Unk2 != 4 {
if pkt.DataType != 4 {
t.Error("field mismatch")
}
})
@@ -433,7 +433,7 @@ func TestBatchParseMultiField(t *testing.T) {
if err := pkt.Parse(bf, ctx); err != nil {
t.Fatal(err)
}
if pkt.Unk0 != 2 {
if pkt.RequestType != 2 {
t.Error("field mismatch")
}
})