Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-22 07:32:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor(mhfpacket): rename MsgMhfUpdateHouse.Unk1 to HasPassword

Browse Source 
Verified via Wii U decompilation of putUpdate_house: the field is set
to 0 when no password is provided, and 1 when a password string is
present. The previous comment "Always 0x01" was inaccurate.
This commit is contained in:
Houmgaor
2026-02-18 22:57:18 +01:00
parent 0d07a1f698
commit 151af1a202
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
network/mhfpacket/msg_mhf_update_house.go
View File

@@ -13,7 +13,7 @@ import (
type MsgMhfUpdateHouse struct { type MsgMhfUpdateHouse struct {
AckHandle uint32 AckHandle uint32
State uint8 State uint8
Unk1 uint8 // Always 0x01 HasPassword uint8 // 0 = no password, 1 = has password
Password string Password string
} }
@@ -26,7 +26,7 @@ func (m *MsgMhfUpdateHouse) Opcode() network.PacketID {
func (m *MsgMhfUpdateHouse) Parse(bf *byteframe.ByteFrame, ctx *clientctx.ClientContext) error { func (m *MsgMhfUpdateHouse) Parse(bf *byteframe.ByteFrame, ctx *clientctx.ClientContext) error {
m.AckHandle = bf.ReadUint32() m.AckHandle = bf.ReadUint32()
m.State = bf.ReadUint8() m.State = bf.ReadUint8()
m.Unk1 = bf.ReadUint8() m.HasPassword = bf.ReadUint8()
bf.ReadUint8() // Zeroed bf.ReadUint8() // Zeroed
bf.ReadUint8() // Zeroed bf.ReadUint8() // Zeroed
bf.ReadUint8() // Password length bf.ReadUint8() // Password length

4
network/mhfpacket/msg_parse_large_test.go
View File

@@ -455,8 +455,8 @@ func TestParseLargeMsgMhfUpdateHouse(t *testing.T) {
if pkt.State != tt.state { if pkt.State != tt.state {
t.Errorf("State = %d, want %d", pkt.State, tt.state) t.Errorf("State = %d, want %d", pkt.State, tt.state)
} }
if pkt.Unk1 != 1 { if pkt.HasPassword != 1 {
t.Errorf("Unk1 = %d, want 1", pkt.Unk1) t.Errorf("HasPassword = %d, want 1", pkt.HasPassword)
} }
if pkt.Password != tt.password { if pkt.Password != tt.password {
t.Errorf("Password = %q, want %q", pkt.Password, tt.password) t.Errorf("Password = %q, want %q", pkt.Password, tt.password)