From 19a49fa0aecb50ec0d7e9f3d6849104fcb4e9312 Mon Sep 17 00:00:00 2001
From: Houmgaor <contact@houmgaor.com>
Date: Mon, 23 Mar 2026 11:59:57 +0100
Subject: [PATCH] fix(migrations): remove explicit BEGIN/COMMIT from migrations
 0012-0015

applyMigration() already wraps each file in a db.Begin()/tx.Commit()
transaction. The inner BEGIN/COMMIT in these files caused the outer
transaction to commit early, leaving applyMigration trying to insert
into schema_version on an idle connection:
  pq: unexpected transaction status idle

Affected: 0012_guild_invites, 0014_return_guilds, 0015_tournament.
---
 server/migrations/sql/0012_guild_invites.sql | 4 ----
 server/migrations/sql/0014_return_guilds.sql | 4 ----
 server/migrations/sql/0015_tournament.sql    | 4 ----
 3 files changed, 12 deletions(-)

diff --git a/server/migrations/sql/0012_guild_invites.sql b/server/migrations/sql/0012_guild_invites.sql
index c013686a4..cd208aa40 100644
--- a/server/migrations/sql/0012_guild_invites.sql
+++ b/server/migrations/sql/0012_guild_invites.sql
@@ -1,5 +1,3 @@
-BEGIN;
-
 -- Dedicated table for guild-initiated scout invitations, separate from
 -- player-initiated applications. This gives each invitation a real serial PK
 -- so the client's InvitationID field can map to an actual database row
@@ -19,5 +17,3 @@ FROM guild_applications
 WHERE application_type = 'invited';
 
 DELETE FROM guild_applications WHERE application_type = 'invited';
-
-COMMIT;
diff --git a/server/migrations/sql/0014_return_guilds.sql b/server/migrations/sql/0014_return_guilds.sql
index 417958e96..afed5b5e2 100644
--- a/server/migrations/sql/0014_return_guilds.sql
+++ b/server/migrations/sql/0014_return_guilds.sql
@@ -1,5 +1 @@
-BEGIN;
-
 ALTER TABLE public.guilds ADD COLUMN IF NOT EXISTS return_type SMALLINT NOT NULL DEFAULT 0;
-
-COMMIT;
diff --git a/server/migrations/sql/0015_tournament.sql b/server/migrations/sql/0015_tournament.sql
index 797698e7b..692e3849b 100644
--- a/server/migrations/sql/0015_tournament.sql
+++ b/server/migrations/sql/0015_tournament.sql
@@ -1,5 +1,3 @@
-BEGIN;
-
 CREATE TABLE IF NOT EXISTS tournaments (
     id          SERIAL PRIMARY KEY,
     name        VARCHAR(64) NOT NULL,
@@ -44,5 +42,3 @@ CREATE TABLE IF NOT EXISTS tournament_results (
     stage_handle  INTEGER NOT NULL DEFAULT 0,
     submitted_at  TIMESTAMPTZ NOT NULL DEFAULT NOW()
 );
-
-COMMIT;