Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2025-12-14 07:55:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Change event quest updating to use transactions rather than directly commiting

Browse Source
This commit is contained in:
Matthew
2023-11-17 22:18:07 -05:00
parent 800e993c1f
commit 233990f452
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
server/channelserver/handlers_quest.go
View File

@@ -205,11 +205,15 @@ func handleMsgMhfEnumerateQuest(s *Session, p mhfpacket.MHFPacket) {
} }
defer rows.Close() defer rows.Close()
// Commit event quest changes to a transaction instead of doing it one by one for to help with performance
transaction, _ := s.server.db.Begin()
for rows.Next() { for rows.Next() {
var id, mark uint32 var id, mark uint32
var questId, activeDuration, inactiveDuration int var questId, activeDuration, inactiveDuration int
var maxPlayers, questType uint8 var maxPlayers, questType uint8
var startTime time.Time var startTime time.Time
err := rows.Scan(&id, &maxPlayers, &questType, &questId, &mark, &startTime, &activeDuration, &inactiveDuration) err := rows.Scan(&id, &maxPlayers, &questType, &questId, &mark, &startTime, &activeDuration, &inactiveDuration)
if err != nil { if err != nil {
continue continue
@@ -219,14 +223,14 @@ func handleMsgMhfEnumerateQuest(s *Session, p mhfpacket.MHFPacket) {
rotationTime := startTime.Add(time.Duration(activeDuration+inactiveDuration) * 24 * time.Hour) rotationTime := startTime.Add(time.Duration(activeDuration+inactiveDuration) * 24 * time.Hour)
if currentTime.After(rotationTime) { if currentTime.After(rotationTime) {
// The rotation time has passed, update the start time and reset the rotation // The rotation time has passed, update the start time and reset the rotation
_, err := s.server.db.Exec("UPDATE event_quests SET start_time = $1 WHERE quest_id = $2", rotationTime, questId) _, err := transaction.Exec("UPDATE event_quests SET start_time = $1 WHERE quest_id = $2", rotationTime, questId)
if err != nil { if err != nil {
return return
} }
} }
// Check if the quest is currently active // Check if the quest is currently active
if currentTime.After(startTime) && currentTime.Sub(startTime) <= time.Duration(activeDuration) * 24 * time.Hour { if currentTime.After(startTime) && currentTime.Sub(startTime) <= time.Duration(activeDuration)*24*time.Hour {
data, err := makeEventQuest(s, rows) data, err := makeEventQuest(s, rows)
if err != nil { if err != nil {
continue continue
@@ -245,6 +249,9 @@ func handleMsgMhfEnumerateQuest(s *Session, p mhfpacket.MHFPacket) {
} }
} }
// Commit transaction so to write to the database.
transaction.Commit()
type tuneValue struct { type tuneValue struct {
ID uint16 ID uint16
Value uint16 Value uint16