Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-27 01:53:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(gacha): validate reward pool before charging currency (#175)

Browse Source 
Filter out gacha entries with no items at the query level (EXISTS
subquery) and reorder Play methods to validate the pool before
calling transact(), so players are never charged for a misconfigured
gacha.
This commit is contained in:
Houmgaor
2026-03-10 11:28:11 +01:00
parent 915e9bc0b0
commit 2365b63e9c
4 changed files with 52 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
server/channelserver/svc_gacha.go
View File

@@ -164,14 +164,17 @@ func rewardsToItems(rewards []GachaReward) []GachaItem {
return items
}
// PlayNormalGacha processes a normal gacha roll: deducts cost, selects random
// rewards, saves items, and returns the result.
// PlayNormalGacha processes a normal gacha roll: validates the reward pool,
// deducts cost, selects random rewards, saves items, and returns the result.
func (svc *GachaService) PlayNormalGacha(userID, charID, gachaID uint32, rollType uint8) (*GachaPlayResult, error) {
rolls, err := svc.transact(userID, charID, gachaID, rollType)
entries, err := svc.gachaRepo.GetRewardPool(gachaID)
if err != nil {
return nil, err
}
entries, err := svc.gachaRepo.GetRewardPool(gachaID)
if len(entries) == 0 {
return nil, errors.New("gacha has no valid reward entries")
}
rolls, err := svc.transact(userID, charID, gachaID, rollType)
if err != nil {
return nil, err
}
@@ -180,9 +183,17 @@ func (svc *GachaService) PlayNormalGacha(userID, charID, gachaID uint32, rollTyp
return &GachaPlayResult{Rewards: rewards}, nil
}
// PlayStepupGacha processes a stepup gacha roll: deducts cost, advances step,
// awards frontier points, selects random + guaranteed rewards, and saves items.
// PlayStepupGacha processes a stepup gacha roll: validates the reward pool,
// deducts cost, advances step, awards frontier points, selects random +
// guaranteed rewards, and saves items.
func (svc *GachaService) PlayStepupGacha(userID, charID, gachaID uint32, rollType uint8) (*StepupPlayResult, error) {
entries, err := svc.gachaRepo.GetRewardPool(gachaID)
if err != nil {
return nil, err
}
if len(entries) == 0 {
return nil, errors.New("gacha has no valid reward entries")
}
rolls, err := svc.transact(userID, charID, gachaID, rollType)
if err != nil {
return nil, err
@@ -197,11 +208,6 @@ func (svc *GachaService) PlayStepupGacha(userID, charID, gachaID uint32, rollTyp
svc.logger.Error("Failed to insert gacha stepup state", zap.Error(err))
}
entries, err := svc.gachaRepo.GetRewardPool(gachaID)
if err != nil {
return nil, err
}
guaranteedItems, _ := svc.gachaRepo.GetGuaranteedItems(rollType, gachaID)
randomRewards := svc.resolveRewards(entries, rolls, false)
@@ -223,14 +229,18 @@ func (svc *GachaService) PlayStepupGacha(userID, charID, gachaID uint32, rollTyp
}, nil
}
// PlayBoxGacha processes a box gacha roll: deducts cost, selects random entries
// without replacement, records drawn entries, saves items, and returns the result.
// PlayBoxGacha processes a box gacha roll: validates the reward pool, deducts
// cost, selects random entries without replacement, records drawn entries,
// saves items, and returns the result.
func (svc *GachaService) PlayBoxGacha(userID, charID, gachaID uint32, rollType uint8) (*GachaPlayResult, error) {
rolls, err := svc.transact(userID, charID, gachaID, rollType)
entries, err := svc.gachaRepo.GetRewardPool(gachaID)
if err != nil {
return nil, err
}
entries, err := svc.gachaRepo.GetRewardPool(gachaID)
if len(entries) == 0 {
return nil, errors.New("gacha has no valid reward entries")
}
rolls, err := svc.transact(userID, charID, gachaID, rollType)
if err != nil {
return nil, err
}