Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-22 07:32:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: re-enable CI lint job and fix ~65 lint errors (partial)

Browse Source 
Re-enable the golangci-lint job in CI (disabled Oct 2025), update to
Go 1.25 and golangci-lint-action v7. Fix errcheck, gosimple S1009,
staticcheck SA4031 and SA2001 errors across 54 files. Remaining ~39
lint errors will be addressed in follow-up commits.
This commit is contained in:
Houmgaor
2026-02-17 17:59:00 +01:00
parent d2b5bb72f8
commit 2a0e3e2c84
54 changed files with 200 additions and 212 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/byteframe/byteframe_setbe_test.go
View File

@@ -22,7 +22,7 @@ func TestByteFrame_SetBE(t *testing.T) {
// Verify write/read works correctly in BE mode after switching
bf.WriteUint16(0x1234)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
got := bf.ReadUint16()
if got != 0x1234 {
t.Errorf("ReadUint16() = 0x%04X, want 0x1234", got)
@@ -50,7 +50,7 @@ func TestByteFrame_LEReadWrite(t *testing.T) {
t.Errorf("LE WriteUint32 bytes: got %X, want 78563412", data)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
got := bf.ReadUint32()
if got != 0x12345678 {
t.Errorf("LE ReadUint32() = 0x%08X, want 0x12345678", got)

8
common/byteframe/byteframe_test.go
View File

@@ -57,7 +57,7 @@ func TestByteFrame_WriteAndReadUint8(t *testing.T) {
bf.WriteUint8(v)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
for i, expected := range values {
got := bf.ReadUint8()
if got != expected {
@@ -83,7 +83,7 @@ func TestByteFrame_WriteAndReadUint16(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := NewByteFrame()
bf.WriteUint16(tt.value)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
got := bf.ReadUint16()
if got != tt.value {
t.Errorf("ReadUint16() = %d, want %d", got, tt.value)
@@ -108,7 +108,7 @@ func TestByteFrame_WriteAndReadUint32(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := NewByteFrame()
bf.WriteUint32(tt.value)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
got := bf.ReadUint32()
if got != tt.value {
t.Errorf("ReadUint32() = %d, want %d", got, tt.value)
@@ -133,7 +133,7 @@ func TestByteFrame_WriteAndReadUint64(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := NewByteFrame()
bf.WriteUint64(tt.value)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
got := bf.ReadUint64()
if got != tt.value {
t.Errorf("ReadUint64() = %d, want %d", got, tt.value)

6
common/mhfitem/mhfitem_test.go
View File

@@ -15,7 +15,7 @@ func TestReadWarehouseItem(t *testing.T) {
bf.WriteUint16(5) // Quantity
bf.WriteUint32(999999) // Unk0
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
item := ReadWarehouseItem(bf)
if item.WarehouseID != 12345 {
@@ -40,7 +40,7 @@ func TestReadWarehouseItem_ZeroWarehouseID(t *testing.T) {
bf.WriteUint16(5) // Quantity
bf.WriteUint32(0) // Unk0
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
item := ReadWarehouseItem(bf)
if item.WarehouseID == 0 {
@@ -247,7 +247,7 @@ func TestReadWarehouseEquipment(t *testing.T) {
// Unk1 (Z1+)
bf.WriteUint16(9999)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
equipment := ReadWarehouseEquipment(bf)
if equipment.WarehouseID != 12345 {

28
common/pascalstring/pascalstring_test.go
View File

@@ -12,7 +12,7 @@ func TestUint8_NoTransform(t *testing.T) {
Uint8(bf, testString, false)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint8()
expectedLength := uint8(len(testString) + 1) // +1 for null terminator
@@ -35,7 +35,7 @@ func TestUint8_WithTransform(t *testing.T) {
Uint8(bf, testString, true)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint8()
if length == 0 {
@@ -55,7 +55,7 @@ func TestUint8_EmptyString(t *testing.T) {
Uint8(bf, testString, false)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint8()
if length != 1 { // Just null terminator
@@ -74,7 +74,7 @@ func TestUint16_NoTransform(t *testing.T) {
Uint16(bf, testString, false)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint16()
expectedLength := uint16(len(testString) + 1)
@@ -95,7 +95,7 @@ func TestUint16_WithTransform(t *testing.T) {
Uint16(bf, testString, true)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint16()
if length == 0 {
@@ -114,7 +114,7 @@ func TestUint16_EmptyString(t *testing.T) {
Uint16(bf, testString, false)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint16()
if length != 1 {
@@ -128,7 +128,7 @@ func TestUint32_NoTransform(t *testing.T) {
Uint32(bf, testString, false)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint32()
expectedLength := uint32(len(testString) + 1)
@@ -149,7 +149,7 @@ func TestUint32_WithTransform(t *testing.T) {
Uint32(bf, testString, true)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint32()
if length == 0 {
@@ -168,7 +168,7 @@ func TestUint32_EmptyString(t *testing.T) {
Uint32(bf, testString, false)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint32()
if length != 1 {
@@ -182,7 +182,7 @@ func TestUint8_LongString(t *testing.T) {
Uint8(bf, testString, false)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint8()
expectedLength := uint8(len(testString) + 1)
@@ -209,7 +209,7 @@ func TestUint16_LongString(t *testing.T) {
Uint16(bf, testString, false)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint16()
expectedLength := uint16(len(testString) + 1)
@@ -265,7 +265,7 @@ func TestAllFunctions_NullTermination(t *testing.T) {
tt.writeFn(bf, testString, false)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
size := tt.readSize(bf)
data := bf.ReadBytes(size)
@@ -289,7 +289,7 @@ func TestTransform_JapaneseCharacters(t *testing.T) {
Uint16(bf, testString, true)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint16()
if length == 0 {
@@ -316,7 +316,7 @@ func TestTransform_InvalidUTF8(t *testing.T) {
Uint8(bf, testString, true)
// Should succeed for ASCII characters
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
length := bf.ReadUint8()
if length == 0 {
t.Error("ASCII string should transform successfully")

2
common/stringstack/stringstack_test.go
View File

@@ -249,7 +249,7 @@ func TestStringStack_SetAfterOperations(t *testing.T) {
s.Push("a")
s.Push("b")
s.Push("c")
s.Pop()
_, _ = s.Pop()
s.Push("d")
// Set should clear everything