fix: re-enable CI lint job and fix ~65 lint errors (partial)

Re-enable the golangci-lint job in CI (disabled Oct 2025), update to
Go 1.25 and golangci-lint-action v7. Fix errcheck, gosimple S1009,
staticcheck SA4031 and SA2001 errors across 54 files. Remaining ~39
lint errors will be addressed in follow-up commits.
This commit is contained in:
Houmgaor
2026-02-17 17:59:00 +01:00
parent d2b5bb72f8
commit 2a0e3e2c84
54 changed files with 200 additions and 212 deletions

View File

@@ -22,7 +22,7 @@ func TestByteFrame_SetBE(t *testing.T) {
// Verify write/read works correctly in BE mode after switching
bf.WriteUint16(0x1234)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
got := bf.ReadUint16()
if got != 0x1234 {
t.Errorf("ReadUint16() = 0x%04X, want 0x1234", got)
@@ -50,7 +50,7 @@ func TestByteFrame_LEReadWrite(t *testing.T) {
t.Errorf("LE WriteUint32 bytes: got %X, want 78563412", data)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
got := bf.ReadUint32()
if got != 0x12345678 {
t.Errorf("LE ReadUint32() = 0x%08X, want 0x12345678", got)

View File

@@ -57,7 +57,7 @@ func TestByteFrame_WriteAndReadUint8(t *testing.T) {
bf.WriteUint8(v)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
for i, expected := range values {
got := bf.ReadUint8()
if got != expected {
@@ -83,7 +83,7 @@ func TestByteFrame_WriteAndReadUint16(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := NewByteFrame()
bf.WriteUint16(tt.value)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
got := bf.ReadUint16()
if got != tt.value {
t.Errorf("ReadUint16() = %d, want %d", got, tt.value)
@@ -108,7 +108,7 @@ func TestByteFrame_WriteAndReadUint32(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := NewByteFrame()
bf.WriteUint32(tt.value)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
got := bf.ReadUint32()
if got != tt.value {
t.Errorf("ReadUint32() = %d, want %d", got, tt.value)
@@ -133,7 +133,7 @@ func TestByteFrame_WriteAndReadUint64(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := NewByteFrame()
bf.WriteUint64(tt.value)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
got := bf.ReadUint64()
if got != tt.value {
t.Errorf("ReadUint64() = %d, want %d", got, tt.value)