fix: re-enable CI lint job and fix ~65 lint errors (partial)

Re-enable the golangci-lint job in CI (disabled Oct 2025), update to
Go 1.25 and golangci-lint-action v7. Fix errcheck, gosimple S1009,
staticcheck SA4031 and SA2001 errors across 54 files. Remaining ~39
lint errors will be addressed in follow-up commits.
This commit is contained in:
Houmgaor
2026-02-17 17:59:00 +01:00
parent d2b5bb72f8
commit 2a0e3e2c84
54 changed files with 200 additions and 212 deletions

View File

@@ -15,7 +15,7 @@ func TestReadWarehouseItem(t *testing.T) {
bf.WriteUint16(5) // Quantity
bf.WriteUint32(999999) // Unk0
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
item := ReadWarehouseItem(bf)
if item.WarehouseID != 12345 {
@@ -40,7 +40,7 @@ func TestReadWarehouseItem_ZeroWarehouseID(t *testing.T) {
bf.WriteUint16(5) // Quantity
bf.WriteUint32(0) // Unk0
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
item := ReadWarehouseItem(bf)
if item.WarehouseID == 0 {
@@ -247,7 +247,7 @@ func TestReadWarehouseEquipment(t *testing.T) {
// Unk1 (Z1+)
bf.WriteUint16(9999)
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
equipment := ReadWarehouseEquipment(bf)
if equipment.WarehouseID != 12345 {