Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-24 08:33:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: re-enable CI lint job and fix ~65 lint errors (partial)

Browse Source 
Re-enable the golangci-lint job in CI (disabled Oct 2025), update to
Go 1.25 and golangci-lint-action v7. Fix errcheck, gosimple S1009,
staticcheck SA4031 and SA2001 errors across 54 files. Remaining ~39
lint errors will be addressed in follow-up commits.
This commit is contained in:
Houmgaor
2026-02-17 17:59:00 +01:00
parent d2b5bb72f8
commit 2a0e3e2c84
54 changed files with 200 additions and 212 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/channelserver/handlers_cast_binary_test.go
View File

@@ -122,7 +122,7 @@ func TestHandleMsgSysCastBinary_DiceCommand(t *testing.T) {
Message: "@dice",
SenderName: "TestPlayer",
}
msg.Build(bf)
_ = msg.Build(bf)
pkt := &mhfpacket.MsgSysCastBinary{
Unk: 0,
@@ -157,7 +157,7 @@ func TestBroadcastTypes(t *testing.T) {
TargetCharIDs: []uint32{1, 2, 3},
RawDataPayload: []byte{0xDE, 0xAD, 0xBE, 0xEF},
}
msg.Build(bf)
_ = msg.Build(bf)
return bf.Data()
},
},
@@ -245,7 +245,7 @@ func TestBinaryMessageTypes(t *testing.T) {
Message: "test",
SenderName: "Player",
}
msg.Build(bf)
_ = msg.Build(bf)
return bf.Data()
},
},
@@ -429,12 +429,12 @@ func TestChatMessageParsing(t *testing.T) {
Message: tt.messageContent,
SenderName: tt.authorName,
}
msg.Build(bf)
_ = msg.Build(bf)
// Parse it back
parseBf := byteframe.NewByteFrameFromBytes(bf.Data())
parseBf.SetLE()
parseBf.Seek(8, 0) // Skip initial bytes
_, _ = parseBf.Seek(8, 0) // Skip initial bytes
message := string(parseBf.ReadNullTerminatedBytes())
author := string(parseBf.ReadNullTerminatedBytes())