fix: re-enable CI lint job and fix ~65 lint errors (partial)

Re-enable the golangci-lint job in CI (disabled Oct 2025), update to
Go 1.25 and golangci-lint-action v7. Fix errcheck, gosimple S1009,
staticcheck SA4031 and SA2001 errors across 54 files. Remaining ~39
lint errors will be addressed in follow-up commits.
This commit is contained in:
Houmgaor
2026-02-17 17:59:00 +01:00
parent d2b5bb72f8
commit 2a0e3e2c84
54 changed files with 200 additions and 212 deletions

View File

@@ -613,8 +613,8 @@ func TestSaveDataSerialization(t *testing.T) {
// Simulate binary serialization
buf := new(bytes.Buffer)
binary.Write(buf, binary.LittleEndian, savedata.CharID)
binary.Write(buf, binary.LittleEndian, savedata.Playtime)
_ = binary.Write(buf, binary.LittleEndian, savedata.CharID)
_ = binary.Write(buf, binary.LittleEndian, savedata.Playtime)
// Should have 8 bytes (4 + 4)
if buf.Len() != 8 {
@@ -625,8 +625,8 @@ func TestSaveDataSerialization(t *testing.T) {
data := buf.Bytes()
var charID uint32
var playtime uint32
binary.Read(bytes.NewReader(data), binary.LittleEndian, &charID)
binary.Read(bytes.NewReader(data[4:]), binary.LittleEndian, &playtime)
_ = binary.Read(bytes.NewReader(data), binary.LittleEndian, &charID)
_ = binary.Read(bytes.NewReader(data[4:]), binary.LittleEndian, &playtime)
if charID != tt.charID || playtime != tt.playtime {
t.Error("serialization round-trip failed")