fix: re-enable CI lint job and fix ~65 lint errors (partial)

Re-enable the golangci-lint job in CI (disabled Oct 2025), update to
Go 1.25 and golangci-lint-action v7. Fix errcheck, gosimple S1009,
staticcheck SA4031 and SA2001 errors across 54 files. Remaining ~39
lint errors will be addressed in follow-up commits.
This commit is contained in:
Houmgaor
2026-02-17 17:59:00 +01:00
parent d2b5bb72f8
commit 2a0e3e2c84
54 changed files with 200 additions and 212 deletions

View File

@@ -179,10 +179,10 @@ func TestAckPacketStructure(t *testing.T) {
var buf bytes.Buffer
// Write opcode (2 bytes, big endian)
binary.Write(&buf, binary.BigEndian, uint16(network.MSG_SYS_ACK))
_ = binary.Write(&buf, binary.BigEndian, uint16(network.MSG_SYS_ACK))
// Write ack handle (4 bytes, big endian)
binary.Write(&buf, binary.BigEndian, tt.ackHandle)
_ = binary.Write(&buf, binary.BigEndian, tt.ackHandle)
// Write data
buf.Write(tt.data)
@@ -590,7 +590,7 @@ func TestSaveDataCorruptionDetection_Integration(t *testing.T) {
// Check that database wasn't updated with corrupted data
var savedName string
db.QueryRow("SELECT name FROM characters WHERE id = $1", charID).Scan(&savedName)
_ = db.QueryRow("SELECT name FROM characters WHERE id = $1", charID).Scan(&savedName)
if savedName == "HackedName" {
t.Error("corrupted save data was incorrectly written to database")
}