mirror of
https://github.com/Mezeporta/Erupe.git
synced 2026-03-22 07:32:32 +01:00
refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces
Move scan loops from handlers into repository methods so that interfaces return typed slices instead of leaking database cursors. This fixes resource leaks (7 of 12 call sites never closed rows) and makes all 12 methods mockable for unit tests. Affected repos: CafeRepo, ShopRepo, EventRepo, RengokuRepo, DivaRepo, ScenarioRepo, MiscRepo, MercenaryRepo. New structs: DivaEvent, MercenaryLoan, GuildHuntCatUsage. EventRepo.GetEventQuests left as-is (requires broader Server refactor).
This commit is contained in:
@@ -254,18 +254,13 @@ func handleMsgMhfGetTrendWeapon(s *Session, p mhfpacket.MHFPacket) {
|
||||
pkt := p.(*mhfpacket.MsgMhfGetTrendWeapon)
|
||||
trendWeapons := [14][3]TrendWeapon{}
|
||||
for i := uint8(0); i < 14; i++ {
|
||||
rows, err := s.server.miscRepo.GetTrendWeapons(i)
|
||||
ids, err := s.server.miscRepo.GetTrendWeapons(i)
|
||||
if err != nil {
|
||||
continue
|
||||
}
|
||||
j := 0
|
||||
for rows.Next() {
|
||||
for j, id := range ids {
|
||||
trendWeapons[i][j].WeaponType = i
|
||||
if err := rows.Scan(&trendWeapons[i][j].WeaponID); err != nil {
|
||||
s.logger.Error("Failed to scan trend weapon", zap.Error(err))
|
||||
break
|
||||
}
|
||||
j++
|
||||
trendWeapons[i][j].WeaponID = id
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user