Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-27 10:03:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(channelserver): resolve all golangci-lint issues and add handler tests

Browse Source 
Fix errcheck violations across 11 repo files by wrapping deferred
rows.Close() and tx.Rollback() calls to discard the error return.
Fix unchecked Scan/Exec calls in guild store tests. Fix staticcheck
SA9003 empty branch in test helpers.

Add 6 mock-based unit tests for GetCharacterSaveData covering nil
savedata, sql.ErrNoRows, DB errors, compressed round-trip,
new-character skip, and config mode/pointer propagation.
This commit is contained in:
Houmgaor
2026-02-21 14:47:25 +01:00
parent bd8e30d570
commit 35d8471d59
13 changed files with 280 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
server/channelserver/repo_mercenary.go
View File

@@ -44,7 +44,7 @@ func (r *MercenaryRepository) GetMercenaryLoans(charID uint32) ([]MercenaryLoan,
if err != nil {
return nil, fmt.Errorf("query mercenary loans: %w", err)
}
defer rows.Close()
defer func() { _ = rows.Close() }()
var result []MercenaryLoan
for rows.Next() {
var l MercenaryLoan
@@ -69,7 +69,7 @@ func (r *MercenaryRepository) GetGuildHuntCatsUsed(charID uint32) ([]GuildHuntCa
if err != nil {
return nil, fmt.Errorf("query guild hunt cats: %w", err)
}
defer rows.Close()
defer func() { _ = rows.Close() }()
var result []GuildHuntCatUsage
for rows.Next() {
var u GuildHuntCatUsage
@@ -90,7 +90,7 @@ func (r *MercenaryRepository) GetGuildAirou(guildID uint32) ([][]byte, error) {
if err != nil {
return nil, fmt.Errorf("query guild airou: %w", err)
}
defer rows.Close()
defer func() { _ = rows.Close() }()
var result [][]byte
for rows.Next() {
var data []byte