Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-28 10:32:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): consolidate two GuildRepo mocks into one

Browse Source 
mockGuildRepoForMail and mockGuildRepoOps each implemented different
subsets of the 68-method GuildRepo interface. Adding any new method
required updating both mocks. Merged into a single mockGuildRepo with
configurable struct fields for error injection and no-op defaults for
the rest.
This commit is contained in:
Houmgaor
2026-02-24 14:13:20 +01:00
parent c1fadd09c3
commit 41a103af9d
14 changed files with 178 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
server/channelserver/handlers_guild_board_test.go
View File

@@ -12,7 +12,7 @@ import (
func TestUpdateGuildMessageBoard_CreatePost(t *testing.T) {
server := createMockServer()
charMock := newMockCharacterRepo()
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
membership: &GuildMember{GuildID: 10, CharID: 1, OrderIndex: 1},
}
guildMock.guild = &Guild{ID: 10}
@@ -49,7 +49,7 @@ func TestUpdateGuildMessageBoard_CreatePost(t *testing.T) {
func TestUpdateGuildMessageBoard_DeletePost(t *testing.T) {
server := createMockServer()
charMock := newMockCharacterRepo()
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
membership: &GuildMember{GuildID: 10, CharID: 1, OrderIndex: 1},
}
guildMock.guild = &Guild{ID: 10}
@@ -74,7 +74,7 @@ func TestUpdateGuildMessageBoard_DeletePost(t *testing.T) {
func TestUpdateGuildMessageBoard_NoGuild(t *testing.T) {
server := createMockServer()
charMock := newMockCharacterRepo()
guildMock := &mockGuildRepoOps{}
guildMock := &mockGuildRepo{}
guildMock.getErr = errNotFound
server.guildRepo = guildMock
server.charRepo = charMock
@@ -98,7 +98,7 @@ func TestUpdateGuildMessageBoard_NoGuild(t *testing.T) {
func TestUpdateGuildMessageBoard_Applicant(t *testing.T) {
server := createMockServer()
charMock := newMockCharacterRepo()
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
hasAppResult: true, // is an applicant
}
guildMock.guild = &Guild{ID: 10}
@@ -128,7 +128,7 @@ func TestUpdateGuildMessageBoard_Applicant(t *testing.T) {
func TestUpdateGuildMessageBoard_HasAppError(t *testing.T) {
server := createMockServer()
charMock := newMockCharacterRepo()
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
hasAppErr: errNotFound, // error checking app status
}
guildMock.guild = &Guild{ID: 10}
@@ -159,7 +159,7 @@ func TestUpdateGuildMessageBoard_HasAppError(t *testing.T) {
func TestEnumerateGuildMessageBoard_NoPosts(t *testing.T) {
server := createMockServer()
charMock := newMockCharacterRepo()
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
posts: []*MessageBoardPost{},
}
guildMock.guild = &Guild{ID: 10}
@@ -185,7 +185,7 @@ func TestEnumerateGuildMessageBoard_NoPosts(t *testing.T) {
func TestEnumerateGuildMessageBoard_WithPosts(t *testing.T) {
server := createMockServer()
charMock := newMockCharacterRepo()
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
posts: []*MessageBoardPost{
{ID: 1, AuthorID: 100, StampID: 5, Title: "Hello", Body: "World", Timestamp: time.Now()},
{ID: 2, AuthorID: 200, StampID: 0, Title: "Test", Body: "Post", Timestamp: time.Now()},
@@ -217,7 +217,7 @@ func TestEnumerateGuildMessageBoard_WithPosts(t *testing.T) {
func TestEnumerateGuildMessageBoard_DBError(t *testing.T) {
server := createMockServer()
charMock := newMockCharacterRepo()
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
listPostsErr: errNotFound,
}
guildMock.guild = &Guild{ID: 10}