Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-28 02:23:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): consolidate two GuildRepo mocks into one

Browse Source 
mockGuildRepoForMail and mockGuildRepoOps each implemented different
subsets of the 68-method GuildRepo interface. Adding any new method
required updating both mocks. Merged into a single mockGuildRepo with
configurable struct fields for error injection and no-op defaults for
the rest.
This commit is contained in:
Houmgaor
2026-02-24 14:13:20 +01:00
parent c1fadd09c3
commit 41a103af9d
14 changed files with 178 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/channelserver/handlers_guild_scout_test.go
View File

@@ -11,7 +11,7 @@ import (
func TestAnswerGuildScout_Accept(t *testing.T) {
server := createMockServer()
mailMock := &mockMailRepo{}
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
application: &GuildApplication{GuildID: 10, CharID: 1},
}
guildMock.guild = &Guild{ID: 10, Name: "TestGuild"}
@@ -46,7 +46,7 @@ func TestAnswerGuildScout_Accept(t *testing.T) {
func TestAnswerGuildScout_Decline(t *testing.T) {
server := createMockServer()
mailMock := &mockMailRepo{}
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
application: &GuildApplication{GuildID: 10, CharID: 1},
}
guildMock.guild = &Guild{ID: 10, Name: "TestGuild"}
@@ -74,7 +74,7 @@ func TestAnswerGuildScout_Decline(t *testing.T) {
func TestAnswerGuildScout_GuildNotFound(t *testing.T) {
server := createMockServer()
guildMock := &mockGuildRepoOps{}
guildMock := &mockGuildRepo{}
guildMock.getErr = errNotFound
server.guildRepo = guildMock
server.mailRepo = &mockMailRepo{}
@@ -100,7 +100,7 @@ func TestAnswerGuildScout_GuildNotFound(t *testing.T) {
func TestAnswerGuildScout_ApplicationMissing(t *testing.T) {
server := createMockServer()
mailMock := &mockMailRepo{}
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
application: nil, // no application found
}
guildMock.guild = &Guild{ID: 10, Name: "TestGuild"}
@@ -133,7 +133,7 @@ func TestAnswerGuildScout_ApplicationMissing(t *testing.T) {
func TestAnswerGuildScout_MailError(t *testing.T) {
server := createMockServer()
mailMock := &mockMailRepo{sendErr: errNotFound}
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
application: &GuildApplication{GuildID: 10, CharID: 1},
}
guildMock.guild = &Guild{ID: 10, Name: "TestGuild"}