Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-22 07:32:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): consolidate two GuildRepo mocks into one

Browse Source 
mockGuildRepoForMail and mockGuildRepoOps each implemented different
subsets of the 68-method GuildRepo interface. Adding any new method
required updating both mocks. Merged into a single mockGuildRepo with
configurable struct fields for error injection and no-op defaults for
the rest.
This commit is contained in:
Houmgaor
2026-02-24 14:13:20 +01:00
parent c1fadd09c3
commit 41a103af9d
14 changed files with 178 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
server/channelserver/svc_guild_test.go
View File

@@ -122,7 +122,7 @@ func TestGuildService_OperateMember(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
membership: tt.membership,
acceptErr: tt.acceptErr,
rejectErr: tt.rejectErr,
@@ -208,7 +208,7 @@ func TestGuildService_Disband(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
guildMock := &mockGuildRepoOps{disbandErr: tt.disbandErr}
guildMock := &mockGuildRepo{disbandErr: tt.disbandErr}
guildMock.guild = tt.guild
svc := newTestGuildService(guildMock, &mockMailRepo{})
@@ -284,7 +284,7 @@ func TestGuildService_ResignLeadership(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
guildMock := &mockGuildRepoOps{getMembersErr: tt.getMembersErr}
guildMock := &mockGuildRepo{getMembersErr: tt.getMembersErr}
guildMock.guild = tt.guild
guildMock.members = tt.members
svc := newTestGuildService(guildMock, &mockMailRepo{})
@@ -356,7 +356,7 @@ func TestGuildService_Leave(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
rejectErr: tt.rejectErr,
removeErr: tt.removeErr,
}
@@ -422,7 +422,7 @@ func TestGuildService_PostScout(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
membership: tt.membership,
hasAppResult: tt.hasApp,
hasAppErr: tt.hasAppErr,
@@ -526,7 +526,7 @@ func TestGuildService_AnswerScout(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
guildMock := &mockGuildRepoOps{
guildMock := &mockGuildRepo{
application: tt.application,
acceptErr: tt.acceptErr,
rejectErr: tt.rejectErr,