fix: resolve all remaining lint errors (errcheck) across 49 files

Fix unchecked error returns on bf.Seek(), db.Exec(), QueryRow().Scan(),
pkt.Build(), logger.Sync(), and binary.Write() calls. The linter now
passes with 0 errors, build compiles, and all tests pass with -race.
This commit is contained in:
Houmgaor
2026-02-17 18:07:38 +01:00
parent 2a0e3e2c84
commit 46bbb6adf9
49 changed files with 497 additions and 497 deletions

View File

@@ -73,7 +73,7 @@ func TestMsgSysPingRoundTrip(t *testing.T) {
}
// Parse
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysPing{}
err = parsed.Parse(bf, ctx)
if err != nil {
@@ -115,7 +115,7 @@ func TestMsgSysTimeRoundTrip(t *testing.T) {
}
// Parse
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysTime{}
err = parsed.Parse(bf, ctx)
if err != nil {
@@ -237,7 +237,7 @@ func TestParserInterface(t *testing.T) {
var p Parser = &MsgSysPing{}
bf := byteframe.NewByteFrame()
bf.WriteUint32(123)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
err := p.Parse(bf, &clientctx.ClientContext{})
if err != nil {
@@ -501,7 +501,7 @@ func TestMsgSysCreateStageParse(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteBytes(tt.data)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysCreateStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -553,7 +553,7 @@ func TestMsgSysEnterStageParse(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteBytes(tt.data)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysEnterStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -602,7 +602,7 @@ func TestMsgSysMoveStageParse(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteBytes(tt.data)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysMoveStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -648,7 +648,7 @@ func TestMsgSysLockStageParse(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteBytes(tt.data)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysLockStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -691,7 +691,7 @@ func TestMsgSysUnlockStageRoundTrip(t *testing.T) {
// Parse should consume a uint16 without error
bf = byteframe.NewByteFrame()
bf.WriteUint16(tt.unk0)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysUnlockStage{}
err = parsed.Parse(bf, ctx)
if err != nil {
@@ -716,7 +716,7 @@ func TestMsgSysBackStageParse(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteBytes(tt.data)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysBackStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -746,7 +746,7 @@ func TestMsgSysLogoutParse(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteBytes(tt.data)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysLogout{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -800,7 +800,7 @@ func TestMsgSysLoginParse(t *testing.T) {
bf.WriteUint16(tt.hardcodedZero1)
bf.WriteUint16(tt.tokenStrLen)
bf.WriteBytes(append([]byte(tt.tokenString), 0x00)) // null terminated
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysLogin{}
err := pkt.Parse(bf, &clientctx.ClientContext{})

File diff suppressed because it is too large Load Diff

View File

@@ -42,7 +42,7 @@ func TestBuildParseDuplicateObject(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysDuplicateObject{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -98,7 +98,7 @@ func TestBuildParsePositionObject(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysPositionObject{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -151,7 +151,7 @@ func TestBuildParseCastedBinary(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysCastedBinary{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -197,7 +197,7 @@ func TestBuildParseLoadRegister(t *testing.T) {
bf.WriteUint8(0) // Zeroed
bf.WriteUint16(0) // Zeroed
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysLoadRegister{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -240,7 +240,7 @@ func TestBuildParseOperateRegister(t *testing.T) {
bf.WriteUint16(uint16(len(tt.payload)))
bf.WriteBytes(tt.payload)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysOperateRegister{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -284,7 +284,7 @@ func TestBuildParseNotifyUserBinary(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysNotifyUserBinary{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -327,7 +327,7 @@ func TestBuildParseTime(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysTime{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -368,7 +368,7 @@ func TestBuildParseUpdateObjectBinary(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysUpdateObjectBinary{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -412,7 +412,7 @@ func TestBuildParseArrangeGuildMember(t *testing.T) {
bf.WriteUint32(id)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfArrangeGuildMember{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -461,7 +461,7 @@ func TestBuildParseEnumerateGuildMember(t *testing.T) {
bf.WriteUint32(tt.allianceID)
bf.WriteUint32(tt.guildID)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfEnumerateGuildMember{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -502,7 +502,7 @@ func TestBuildParseStateCampaign(t *testing.T) {
bf.WriteUint32(tt.campaignID)
bf.WriteUint16(tt.unk1)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfStateCampaign{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -545,7 +545,7 @@ func TestBuildParseApplyCampaign(t *testing.T) {
bf.WriteUint16(tt.unk1)
bf.WriteBytes(tt.unk2)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfApplyCampaign{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -593,7 +593,7 @@ func TestBuildParseEnumerateCampaign(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfEnumerateCampaign{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -635,7 +635,7 @@ func TestBuildParseEnumerateEvent(t *testing.T) {
bf.WriteUint16(0) // Zeroed (discarded by Parse)
bf.WriteUint16(0) // Zeroed (discarded by Parse)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfEnumerateEvent{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -675,7 +675,7 @@ func TestBuildParseAddUdTacticsPoint(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfAddUdTacticsPoint{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -722,7 +722,7 @@ func TestBuildParseApplyDistItem(t *testing.T) {
bf.WriteUint32(tt.unk2) // Read when RealClientMode >= G8
bf.WriteUint32(tt.unk3) // Read when RealClientMode >= G10
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfApplyDistItem{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -778,7 +778,7 @@ func TestBuildParseEnumerateDistItem(t *testing.T) {
bf.WriteUint16(original.Unk2)
bf.WriteUint8(0) // Unk3 length (for Z1+ client mode)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfEnumerateDistItem{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -827,7 +827,7 @@ func TestBuildParseAcquireExchangeShop(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfAcquireExchangeShop{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -852,7 +852,7 @@ func TestBuildParseDisplayedAchievement(t *testing.T) {
ctx := &clientctx.ClientContext{}
bf := byteframe.NewByteFrame()
bf.WriteUint8(0) // Zeroed (discarded by Parse)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfDisplayedAchievement{}
if err := parsed.Parse(bf, ctx); err != nil {
@@ -885,7 +885,7 @@ func TestBuildParseAddKouryouPoint(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfAddKouryouPoint{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -920,7 +920,7 @@ func TestBuildParseCheckDailyCafepoint(t *testing.T) {
bf.WriteUint32(tt.ackHandle)
bf.WriteUint32(tt.unk)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfCheckDailyCafepoint{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -959,7 +959,7 @@ func TestBuildParsePing(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysPing{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -995,7 +995,7 @@ func TestBuildParseDeleteObject(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysDeleteObject{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -1031,7 +1031,7 @@ func TestBuildParseNotifyRegister(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysNotifyRegister{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -1050,7 +1050,7 @@ func TestBuildParseUnlockStage(t *testing.T) {
ctx := &clientctx.ClientContext{}
bf := byteframe.NewByteFrame()
bf.WriteUint16(0) // Zeroed (discarded by Parse)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysUnlockStage{}
if err := parsed.Parse(bf, ctx); err != nil {
@@ -1080,7 +1080,7 @@ func TestBuildParseUnlockGlobalSema(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysUnlockGlobalSema{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -1137,7 +1137,7 @@ func TestBuildParseCastedBinaryPayloadIntegrity(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysCastedBinary{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -1173,7 +1173,7 @@ func TestBuildParseOperateRegisterPayloadIntegrity(t *testing.T) {
bf.WriteUint16(uint16(len(payload))) // dataSize
bf.WriteBytes(payload)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysOperateRegister{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -1202,7 +1202,7 @@ func TestBuildParseArrangeGuildMemberEmptySlice(t *testing.T) {
t.Errorf("wrote %d bytes, want 10 for empty CharIDs", len(bf.Data()))
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfArrangeGuildMember{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -1279,7 +1279,7 @@ func TestBuildParseTimeBooleanEncoding(t *testing.T) {
t.Errorf("Boolean false encoded as %d, want 0", data[0])
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysTime{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -1317,7 +1317,7 @@ func TestBuildParseSysAckBufferSmall(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysAck{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -1358,7 +1358,7 @@ func TestBuildParseSysAckExtendedSize(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysAck{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -1388,7 +1388,7 @@ func TestBuildParseSysAckNonBuffer(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysAck{}
if err := parsed.Parse(bf, ctx); err != nil {
t.Fatalf("Parse() error = %v", err)

View File

@@ -513,7 +513,7 @@ func TestAckHandlePacketsParse(t *testing.T) {
for i := 0; i < 32; i++ {
bf.WriteUint32(uint32(i))
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
// Parse should not panic
err := pkt.Parse(bf, ctx)
@@ -543,7 +543,7 @@ func TestAddAchievementParse(t *testing.T) {
bf.WriteUint8(tt.achievementID)
bf.WriteUint16(tt.unk1)
bf.WriteUint16(tt.unk2)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAddAchievement{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -583,7 +583,7 @@ func TestGetAchievementParse(t *testing.T) {
bf.WriteUint32(tt.ackHandle)
bf.WriteUint32(tt.charID)
bf.WriteUint32(tt.unk1)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfGetAchievement{}
err := pkt.Parse(bf, &clientctx.ClientContext{})

View File

@@ -35,7 +35,7 @@ func TestMsgMhfAcquireCafeItemParse(t *testing.T) {
bf.WriteUint32(1000) // PointCost (uint32)
bf.WriteUint16(0) // Unk0
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAcquireCafeItem{}
ctx := &clientctx.ClientContext{}
@@ -94,7 +94,7 @@ func TestMsgMhfAcquireCafeItemParseUint32PointCost(t *testing.T) {
bf.WriteUint32(tt.pointCost)
bf.WriteUint16(0) // Unk0
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAcquireCafeItem{}
ctx := &clientctx.ClientContext{}
@@ -123,7 +123,7 @@ func TestMsgMhfAcquireCafeItemParseFieldOrder(t *testing.T) {
bf.WriteUint32(0xBBCCDDEE) // PointCost (offset 10-13)
bf.WriteUint16(0xFF00) // Unk0 (offset 14-15)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAcquireCafeItem{}
err := pkt.Parse(bf, &clientctx.ClientContext{})

View File

@@ -48,7 +48,7 @@ func TestMsgMhfAcquireGuildTresureParse(t *testing.T) {
bf.WriteUint32(tt.ackHandle)
bf.WriteUint32(tt.huntID)
bf.WriteBool(tt.unk)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAcquireGuildTresure{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -89,7 +89,7 @@ func TestMsgMhfAcquireTitleParse(t *testing.T) {
for _, id := range tt.titleIDs {
bf.WriteUint16(id)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAcquireTitle{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -130,7 +130,7 @@ func TestMsgMhfAcquireDistItemParse(t *testing.T) {
bf.WriteUint32(tt.ackHandle)
bf.WriteUint8(tt.distributionType)
bf.WriteUint32(tt.distributionID)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAcquireDistItem{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -174,7 +174,7 @@ func TestMsgMhfAcquireMonthlyItemParse(t *testing.T) {
bf.WriteUint16(tt.unk2)
bf.WriteUint32(tt.unk3)
bf.WriteUint32(0) // Zeroed (consumed by Parse)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAcquireMonthlyItem{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -228,7 +228,7 @@ func TestAcquirePacketEdgeCases(t *testing.T) {
bf.WriteUint32(1)
bf.WriteUint32(0xFFFFFFFF)
bf.WriteBool(true)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAcquireGuildTresure{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -247,7 +247,7 @@ func TestAcquirePacketEdgeCases(t *testing.T) {
bf.WriteUint32(1)
bf.WriteUint8(i)
bf.WriteUint32(12345)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAcquireDistItem{}
err := pkt.Parse(bf, &clientctx.ClientContext{})

View File

@@ -38,7 +38,7 @@ func TestMsgMhfUpdateGuacotParse_SingleEntry(t *testing.T) {
bf.WriteBytes([]byte("Porky"))
pkt := &MsgMhfUpdateGuacot{}
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
err := pkt.Parse(bf, nil)
if err != nil {
t.Fatalf("Parse() error: %v", err)
@@ -99,7 +99,7 @@ func TestMsgMhfUpdateGuacotParse_MultipleEntries(t *testing.T) {
}
pkt := &MsgMhfUpdateGuacot{}
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
err := pkt.Parse(bf, nil)
if err != nil {
t.Fatalf("Parse() error: %v", err)
@@ -129,7 +129,7 @@ func TestMsgMhfUpdateGuacotParse_ZeroEntries(t *testing.T) {
bf.WriteUint16(0) // Zeroed
pkt := &MsgMhfUpdateGuacot{}
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
err := pkt.Parse(bf, nil)
if err != nil {
t.Fatalf("Parse() error: %v", err)
@@ -160,7 +160,7 @@ func TestMsgMhfUpdateGuacotParse_DeletionEntry(t *testing.T) {
bf.WriteUint8(0) // Empty name
pkt := &MsgMhfUpdateGuacot{}
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
err := pkt.Parse(bf, nil)
if err != nil {
t.Fatalf("Parse() error: %v", err)
@@ -187,7 +187,7 @@ func TestMsgMhfUpdateGuacotParse_EmptyName(t *testing.T) {
bf.WriteUint8(0) // Empty name
pkt := &MsgMhfUpdateGuacot{}
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
err := pkt.Parse(bf, nil)
if err != nil {
t.Fatalf("Parse() error: %v", err)
@@ -205,7 +205,7 @@ func TestMsgMhfEnumerateGuacotParse(t *testing.T) {
bf.WriteUint16(0) // Zeroed
pkt := &MsgMhfEnumerateGuacot{}
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
err := pkt.Parse(bf, nil)
if err != nil {
t.Fatalf("Parse() error: %v", err)
@@ -251,7 +251,7 @@ func TestGoocooStruct_Data1Size(t *testing.T) {
bf.WriteUint8(0) // No name
pkt := &MsgMhfUpdateGuacot{}
bf.Seek(0, 0)
_, _ = bf.Seek(0, 0)
_ = pkt.Parse(bf, nil)
g := pkt.Goocoos[0]

View File

@@ -517,7 +517,7 @@ func TestAchievementPacketParse(t *testing.T) {
bf.WriteUint8(5) // AchievementID
bf.WriteUint16(100) // Unk1
bf.WriteUint16(200) // Unk2
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAddAchievement{}
err := pkt.Parse(bf, &clientctx.ClientContext{})

View File

@@ -31,7 +31,7 @@ func TestParseLargeMsgSysUpdateRightBuild(t *testing.T) {
t.Fatalf("Build() wrote %d bytes, want at least 12", len(data))
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
if bf.ReadUint32() != 0x12345678 {
t.Error("ClientRespAckHandle mismatch")
}
@@ -54,7 +54,7 @@ func TestParseLargeMsgMhfOperateWarehouse(t *testing.T) {
bf.WriteUint16(0) // Unk
bf.WriteBytes([]byte("TestBox"))
bf.WriteUint8(0) // null terminator
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfOperateWarehouse{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -89,7 +89,7 @@ func TestParseLargeMsgMhfOperateWarehouseEquip(t *testing.T) {
bf.WriteUint16(0) // Unk
bf.WriteBytes([]byte("Arms"))
bf.WriteUint8(0) // null terminator
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfOperateWarehouse{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -129,7 +129,7 @@ func TestParseLargeMsgMhfLoadHouse(t *testing.T) {
bf.WriteUint8(uint8(len(tt.password) + 1)) // Password length
bf.WriteBytes([]byte(tt.password))
bf.WriteUint8(0) // null terminator
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfLoadHouse{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -168,7 +168,7 @@ func TestParseLargeMsgMhfSendMail(t *testing.T) {
bf.WriteUint8(0) // null terminator for Subject
bf.WriteBytes([]byte("Hello World"))
bf.WriteUint8(0) // null terminator for Body
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfSendMail{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -229,7 +229,7 @@ func TestParseLargeMsgMhfApplyBbsArticle(t *testing.T) {
copy(descBytes, "This is a description")
bf.WriteBytes(descBytes)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfApplyBbsArticle{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -267,7 +267,7 @@ func TestParseLargeMsgMhfChargeFesta(t *testing.T) {
bf.WriteUint16(20) // soul value 2
bf.WriteUint16(30) // soul value 3
bf.WriteUint8(0) // Unk
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfChargeFesta{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -302,7 +302,7 @@ func TestParseLargeMsgMhfChargeFestaZeroSouls(t *testing.T) {
bf.WriteUint32(0) // GuildID
bf.WriteUint16(0) // soul count = 0
bf.WriteUint8(0) // Unk
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfChargeFesta{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -325,7 +325,7 @@ func TestParseLargeMsgMhfOperateJoint(t *testing.T) {
bf.WriteUint8(3) // dataLen = 3
bf.WriteBytes([]byte{0xAA, 0xBB, 0xCC, 0xDD}) // Data1 (always 4 bytes)
bf.WriteBytes([]byte{0x01, 0x02, 0x03}) // Data2 (dataLen bytes)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfOperateJoint{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -361,7 +361,7 @@ func TestParseLargeMsgMhfOperationInvGuild(t *testing.T) {
bf.WriteUint8(7) // DaysActive
bf.WriteUint8(3) // PlayStyle
bf.WriteUint8(2) // GuildRequest
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfOperationInvGuild{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -400,7 +400,7 @@ func TestParseLargeMsgMhfSaveMercenary(t *testing.T) {
bf.WriteUint32(uint32(len(mercData))) // dataSize
bf.WriteUint32(0) // Merc index (skipped)
bf.WriteBytes(mercData)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfSaveMercenary{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -442,7 +442,7 @@ func TestParseLargeMsgMhfUpdateHouse(t *testing.T) {
bf.WriteUint8(uint8(len(tt.password) + 1)) // Password length
bf.WriteBytes([]byte(tt.password))
bf.WriteUint8(0) // null terminator
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfUpdateHouse{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -477,7 +477,7 @@ func TestParseLargeMsgSysCreateAcquireSemaphore(t *testing.T) {
bf.WriteUint8(4) // PlayerCount
bf.WriteUint8(uint8(len(semBytes))) // SemaphoreIDLength
bf.WriteBytes(semBytes)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysCreateAcquireSemaphore{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -509,7 +509,7 @@ func TestParseLargeMsgMhfOperateGuild(t *testing.T) {
bf.WriteUint8(uint8(len(dataPayload))) // dataLen
bf.WriteBytes([]byte{0x01, 0x02, 0x03, 0x04}) // Data1 (always 4 bytes)
bf.WriteBytes(dataPayload) // Data2 (dataLen bytes)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfOperateGuild{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -549,7 +549,7 @@ func TestParseLargeMsgMhfReadBeatLevel(t *testing.T) {
for _, id := range ids {
bf.WriteUint32(id)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfReadBeatLevel{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -593,7 +593,7 @@ func TestParseLargeMsgSysCreateObject(t *testing.T) {
bf.WriteFloat32(tt.y)
bf.WriteFloat32(tt.z)
bf.WriteUint32(tt.unk0)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysCreateObject{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -629,7 +629,7 @@ func TestParseLargeMsgSysLockGlobalSema(t *testing.T) {
bf.WriteUint8(0) // null terminator
bf.WriteBytes([]byte("channel_01"))
bf.WriteUint8(0) // null terminator
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysLockGlobalSema{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -661,7 +661,7 @@ func TestParseLargeMsgMhfCreateJoint(t *testing.T) {
bf.WriteUint32(15) // len (unused)
bf.WriteBytes([]byte("Alliance01"))
bf.WriteUint8(0) // null terminator
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfCreateJoint{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -686,7 +686,7 @@ func TestParseLargeMsgMhfGetUdTacticsRemainingPoint(t *testing.T) {
bf.WriteUint32(100) // Unk0
bf.WriteUint32(200) // Unk1
bf.WriteUint32(300) // Unk2
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfGetUdTacticsRemainingPoint{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -715,7 +715,7 @@ func TestParseLargeMsgMhfPostCafeDurationBonusReceived(t *testing.T) {
bf.WriteUint32(1001) // CafeBonusID[0]
bf.WriteUint32(1002) // CafeBonusID[1]
bf.WriteUint32(1003) // CafeBonusID[2]
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfPostCafeDurationBonusReceived{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -741,7 +741,7 @@ func TestParseLargeMsgMhfPostCafeDurationBonusReceivedEmpty(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteUint32(1) // AckHandle
bf.WriteUint32(0) // count = 0
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfPostCafeDurationBonusReceived{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -759,7 +759,7 @@ func TestParseLargeMsgMhfRegistGuildAdventureDiva(t *testing.T) {
bf.WriteUint32(5) // Destination
bf.WriteUint32(1000) // Charge
bf.WriteUint32(42) // CharID (skipped)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfRegistGuildAdventureDiva{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -784,7 +784,7 @@ func TestParseLargeMsgMhfStateFestaG(t *testing.T) {
bf.WriteUint32(100) // FestaID
bf.WriteUint32(200) // GuildID
bf.WriteUint16(0) // Hardcoded 0
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfStateFestaG{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -809,7 +809,7 @@ func TestParseLargeMsgMhfStateFestaU(t *testing.T) {
bf.WriteUint32(300) // FestaID
bf.WriteUint32(400) // GuildID
bf.WriteUint16(0) // Hardcoded 0
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfStateFestaU{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -835,7 +835,7 @@ func TestParseLargeMsgSysEnumerateStage(t *testing.T) {
bf.WriteUint8(0) // skipped byte
bf.WriteBytes([]byte("quest_"))
bf.WriteUint8(0) // null terminator
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysEnumerateStage{}
if err := pkt.Parse(bf, nil); err != nil {
@@ -861,7 +861,7 @@ func TestParseLargeMsgSysReserveStage(t *testing.T) {
bf.WriteUint8(0x11) // Ready
bf.WriteUint8(uint8(len(stageBytes))) // stageIDLength
bf.WriteBytes(stageBytes)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysReserveStage{}
if err := pkt.Parse(bf, nil); err != nil {

View File

@@ -34,7 +34,7 @@ func TestParseMediumVoteFesta(t *testing.T) {
bf.WriteUint32(tt.guildID)
bf.WriteUint32(tt.trialID)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfVoteFesta{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -79,7 +79,7 @@ func TestParseMediumAcquireSemaphore(t *testing.T) {
bf.WriteUint8(uint8(len(idBytes)))
bf.WriteBytes(idBytes)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysAcquireSemaphore{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -117,7 +117,7 @@ func TestParseMediumCheckSemaphore(t *testing.T) {
bf.WriteUint8(uint8(len(idBytes)))
bf.WriteBytes(idBytes)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysCheckSemaphore{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -154,7 +154,7 @@ func TestParseMediumGetUserBinary(t *testing.T) {
bf.WriteUint32(tt.charID)
bf.WriteUint8(tt.binaryType)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysGetUserBinary{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -193,7 +193,7 @@ func TestParseMediumSetObjectBinary(t *testing.T) {
bf.WriteUint16(uint16(len(tt.payload)))
bf.WriteBytes(tt.payload)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysSetObjectBinary{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -232,7 +232,7 @@ func TestParseMediumSetUserBinary(t *testing.T) {
bf.WriteUint16(uint16(len(tt.payload)))
bf.WriteBytes(tt.payload)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysSetUserBinary{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -272,7 +272,7 @@ func TestParseMediumGetUdRanking(t *testing.T) {
bf.WriteUint32(tt.ack)
bf.WriteUint8(tt.unk0)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfGetUdRanking{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -307,7 +307,7 @@ func TestParseMediumGetUdTacticsRanking(t *testing.T) {
bf.WriteUint32(tt.ack)
bf.WriteUint32(tt.guildID)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfGetUdTacticsRanking{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -344,7 +344,7 @@ func TestParseMediumRegistGuildTresure(t *testing.T) {
bf.WriteBytes(tt.data)
bf.WriteUint32(0) // trailing uint32 that is read and discarded
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfRegistGuildTresure{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -375,7 +375,7 @@ func TestParseMediumUpdateMyhouseInfo(t *testing.T) {
}
bf.WriteBytes(payload)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfUpdateMyhouseInfo{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -397,7 +397,7 @@ func TestParseMediumUpdateMyhouseInfo(t *testing.T) {
bf.WriteUint32(0)
bf.WriteBytes(make([]byte, 0x16A))
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfUpdateMyhouseInfo{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -525,7 +525,7 @@ func TestParseMediumAckHandleOnlyBatch(t *testing.T) {
t.Run(tc.name+"/ack_"+ackHex(ackVal), func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteUint32(ackVal)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
err := tc.pkt.Parse(bf, ctx)
if err != nil {
@@ -545,7 +545,7 @@ func TestParseMediumAckHandleOnlyVerifyValues(t *testing.T) {
makeFrame := func() *byteframe.ByteFrame {
bf := byteframe.NewByteFrame()
bf.WriteUint32(ack)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
return bf
}
@@ -735,7 +735,7 @@ func TestParseMediumAckHandleOnlyVerifyValues(t *testing.T) {
func TestParseMediumDeleteUser(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteUint32(12345)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysDeleteUser{}
err := pkt.Parse(bf, nil)
@@ -752,7 +752,7 @@ func TestParseMediumDeleteUser(t *testing.T) {
func TestParseMediumInsertUser(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteUint32(12345)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysInsertUser{}
err := pkt.Parse(bf, nil)

View File

@@ -65,7 +65,7 @@ func TestParseSmallNotImplemented(t *testing.T) {
bf := byteframe.NewByteFrame()
// Write some padding bytes so Parse has data available if it tries to read.
bf.WriteUint32(0)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
err := tc.pkt.Parse(bf, ctx)
if err == nil {
@@ -116,7 +116,7 @@ func TestParseSmallLogout(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteUint8(tt.unk0)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysLogout{}
err := pkt.Parse(bf, ctx)
@@ -142,7 +142,7 @@ func TestParseSmallEnumerateHouse(t *testing.T) {
bf.WriteUint8(2) // Method
bf.WriteUint16(100) // Unk
bf.WriteUint8(0) // lenName = 0 (no name)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfEnumerateHouse{}
err := pkt.Parse(bf, ctx)
@@ -173,7 +173,7 @@ func TestParseSmallEnumerateHouse(t *testing.T) {
nameBytes := []byte("Test\x00")
bf.WriteUint8(uint8(len(nameBytes))) // lenName > 0
bf.WriteBytes(nameBytes) // null-terminated name
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfEnumerateHouse{}
err := pkt.Parse(bf, ctx)

View File

@@ -14,7 +14,7 @@ func TestMsgMhfGetAchievementDetailedParse(t *testing.T) {
bf.WriteUint32(0x12345678) // AckHandle
bf.WriteUint32(54321) // CharID
bf.WriteUint32(99999) // Unk1
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfGetAchievement{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -36,7 +36,7 @@ func TestMsgMhfAddAchievementDetailedParse(t *testing.T) {
bf.WriteUint8(42) // AchievementID
bf.WriteUint16(12345) // Unk1
bf.WriteUint16(0xFFFF) // Unk2 - max value
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfAddAchievement{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -78,7 +78,7 @@ func TestMsgSysCastBinaryDetailedParse(t *testing.T) {
bf.WriteUint8(tt.messageType)
bf.WriteUint16(uint16(len(tt.payload)))
bf.WriteBytes(tt.payload)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysCastBinary{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -116,7 +116,7 @@ func TestMsgSysLogoutDetailedParse(t *testing.T) {
for _, tt := range tests {
bf := byteframe.NewByteFrame()
bf.WriteUint8(tt.unk0)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysLogout{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -144,7 +144,7 @@ func TestMsgSysBackStageDetailedParse(t *testing.T) {
for _, tt := range tests {
bf := byteframe.NewByteFrame()
bf.WriteUint32(tt.ackHandle)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysBackStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -171,7 +171,7 @@ func TestMsgSysPingDetailedParse(t *testing.T) {
for _, tt := range tests {
bf := byteframe.NewByteFrame()
bf.WriteUint32(tt.ackHandle)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysPing{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -200,7 +200,7 @@ func TestMsgSysTimeDetailedParse(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteBool(tt.getRemoteTime)
bf.WriteUint32(tt.timestamp)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysTime{}
err := pkt.Parse(bf, &clientctx.ClientContext{})

View File

@@ -65,7 +65,7 @@ func TestMsgSysAckRoundTrip(t *testing.T) {
}
// Parse
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysAck{}
err = parsed.Parse(bf, ctx)
if err != nil {
@@ -109,7 +109,7 @@ func TestMsgSysAckLargePayload(t *testing.T) {
}
// Parse
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysAck{}
err = parsed.Parse(bf, ctx)
if err != nil {
@@ -206,7 +206,7 @@ func TestMsgSysAckNonBufferResponse(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysAck{}
err = parsed.Parse(bf, ctx)
if err != nil {
@@ -235,7 +235,7 @@ func TestMsgSysAckNonBufferShortData(t *testing.T) {
t.Fatalf("Build() error = %v", err)
}
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgSysAck{}
err = parsed.Parse(bf, ctx)
if err != nil {

View File

@@ -31,7 +31,7 @@ func TestMsgSysCastBinaryParse(t *testing.T) {
bf.WriteUint8(tt.messageType)
bf.WriteUint16(uint16(len(tt.payload)))
bf.WriteBytes(tt.payload)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysCastBinary{}
err := pkt.Parse(bf, &clientctx.ClientContext{})

View File

@@ -55,7 +55,7 @@ func TestMsgSysCreateStageFields(t *testing.T) {
stageIDBytes := []byte(tt.stageID)
bf.WriteUint8(uint8(len(stageIDBytes)))
bf.WriteBytes(append(stageIDBytes, 0x00))
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysCreateStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -99,7 +99,7 @@ func TestMsgSysEnterStageFields(t *testing.T) {
stageIDBytes := []byte(tt.stageID)
bf.WriteUint8(uint8(len(stageIDBytes)))
bf.WriteBytes(append(stageIDBytes, 0x00))
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysEnterStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -139,7 +139,7 @@ func TestMsgSysMoveStageFields(t *testing.T) {
stageIDBytes := []byte(tt.stageID)
bf.WriteUint8(uint8(len(stageIDBytes)))
bf.WriteBytes(stageIDBytes)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysMoveStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -181,7 +181,7 @@ func TestMsgSysLockStageFields(t *testing.T) {
stageIDBytes := []byte(tt.stageID)
bf.WriteUint8(uint8(len(stageIDBytes)))
bf.WriteBytes(append(stageIDBytes, 0x00))
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysLockStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -215,7 +215,7 @@ func TestMsgSysUnlockStageFields(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteUint16(tt.unk0)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysUnlockStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -242,7 +242,7 @@ func TestMsgSysBackStageFields(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteUint32(tt.handle)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysBackStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -271,7 +271,7 @@ func TestStageIDEdgeCases(t *testing.T) {
bf.WriteUint8(4)
bf.WriteUint8(uint8(len(longID)))
bf.WriteBytes(append(longID, 0x00))
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysCreateStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})
@@ -293,7 +293,7 @@ func TestStageIDEdgeCases(t *testing.T) {
bf.WriteUint8(0)
bf.WriteUint8(uint8(len(stageID)))
bf.WriteBytes([]byte(stageID))
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysEnterStage{}
err := pkt.Parse(bf, &clientctx.ClientContext{})