Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-22 07:32:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve all remaining lint errors (errcheck) across 49 files

Browse Source 
Fix unchecked error returns on bf.Seek(), db.Exec(), QueryRow().Scan(),
pkt.Build(), logger.Sync(), and binary.Write() calls. The linter now
passes with 0 errors, build compiles, and all tests pass with -race.
This commit is contained in:
Houmgaor
2026-02-17 18:07:38 +01:00
parent 2a0e3e2c84
commit 46bbb6adf9
49 changed files with 497 additions and 497 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
network/mhfpacket/msg_parse_medium_test.go
View File

@@ -34,7 +34,7 @@ func TestParseMediumVoteFesta(t *testing.T) {
bf.WriteUint32(tt.guildID)
bf.WriteUint32(tt.trialID)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfVoteFesta{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -79,7 +79,7 @@ func TestParseMediumAcquireSemaphore(t *testing.T) {
bf.WriteUint8(uint8(len(idBytes)))
bf.WriteBytes(idBytes)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysAcquireSemaphore{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -117,7 +117,7 @@ func TestParseMediumCheckSemaphore(t *testing.T) {
bf.WriteUint8(uint8(len(idBytes)))
bf.WriteBytes(idBytes)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysCheckSemaphore{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -154,7 +154,7 @@ func TestParseMediumGetUserBinary(t *testing.T) {
bf.WriteUint32(tt.charID)
bf.WriteUint8(tt.binaryType)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysGetUserBinary{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -193,7 +193,7 @@ func TestParseMediumSetObjectBinary(t *testing.T) {
bf.WriteUint16(uint16(len(tt.payload)))
bf.WriteBytes(tt.payload)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysSetObjectBinary{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -232,7 +232,7 @@ func TestParseMediumSetUserBinary(t *testing.T) {
bf.WriteUint16(uint16(len(tt.payload)))
bf.WriteBytes(tt.payload)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysSetUserBinary{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -272,7 +272,7 @@ func TestParseMediumGetUdRanking(t *testing.T) {
bf.WriteUint32(tt.ack)
bf.WriteUint8(tt.unk0)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfGetUdRanking{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -307,7 +307,7 @@ func TestParseMediumGetUdTacticsRanking(t *testing.T) {
bf.WriteUint32(tt.ack)
bf.WriteUint32(tt.guildID)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfGetUdTacticsRanking{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -344,7 +344,7 @@ func TestParseMediumRegistGuildTresure(t *testing.T) {
bf.WriteBytes(tt.data)
bf.WriteUint32(0) // trailing uint32 that is read and discarded
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfRegistGuildTresure{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -375,7 +375,7 @@ func TestParseMediumUpdateMyhouseInfo(t *testing.T) {
}
bf.WriteBytes(payload)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfUpdateMyhouseInfo{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -397,7 +397,7 @@ func TestParseMediumUpdateMyhouseInfo(t *testing.T) {
bf.WriteUint32(0)
bf.WriteBytes(make([]byte, 0x16A))
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgMhfUpdateMyhouseInfo{}
if err := pkt.Parse(bf, nil); err != nil {
t.Fatalf("Parse() error = %v", err)
@@ -525,7 +525,7 @@ func TestParseMediumAckHandleOnlyBatch(t *testing.T) {
t.Run(tc.name+"/ack_"+ackHex(ackVal), func(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteUint32(ackVal)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
err := tc.pkt.Parse(bf, ctx)
if err != nil {
@@ -545,7 +545,7 @@ func TestParseMediumAckHandleOnlyVerifyValues(t *testing.T) {
makeFrame := func() *byteframe.ByteFrame {
bf := byteframe.NewByteFrame()
bf.WriteUint32(ack)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
return bf
}
@@ -735,7 +735,7 @@ func TestParseMediumAckHandleOnlyVerifyValues(t *testing.T) {
func TestParseMediumDeleteUser(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteUint32(12345)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysDeleteUser{}
err := pkt.Parse(bf, nil)
@@ -752,7 +752,7 @@ func TestParseMediumDeleteUser(t *testing.T) {
func TestParseMediumInsertUser(t *testing.T) {
bf := byteframe.NewByteFrame()
bf.WriteUint32(12345)
bf.Seek(0, io.SeekStart)
_, _ = bf.Seek(0, io.SeekStart)
pkt := &MsgSysInsertUser{}
err := pkt.Parse(bf, nil)