Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-25 09:03:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(scenario): enforce scenarioChunkSizeLimit in CompileScenarioJSON

Browse Source 
The constant was declared and documented but never used, causing a
golangci-lint failure. Wire it into compileScenario() so oversized
chunks are rejected with a clear error rather than silently served
to the client (which discards them per FUN_11525c60 RE findings).
This commit is contained in:
Houmgaor
2026-03-23 11:19:50 +01:00
parent d1d3bb8698
commit 470a761191
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
server/channelserver/scenario_json.go
View File

@@ -349,6 +349,12 @@ func compileScenario(s *ScenarioJSON) ([]byte, error) {
} }
} }
for i, chunk := range [][]byte{chunk0, chunk1, chunk2} {
if len(chunk) > scenarioChunkSizeLimit {
return nil, fmt.Errorf("chunk%d size %d exceeds client limit of %d bytes", i, len(chunk), scenarioChunkSizeLimit)
}
}
var buf bytes.Buffer var buf bytes.Buffer
// Container header: c0_size, c1_size (big-endian u32) // Container header: c0_size, c1_size (big-endian u32)
_ = binary.Write(&buf, binary.BigEndian, uint32(len(chunk0))) _ = binary.Write(&buf, binary.BigEndian, uint32(len(chunk0)))