Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-22 07:32:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(channelserver): handle silently discarded errors across handlers

Browse Source 
Replace ~17 instances of '_ =' / '_ :=' with proper error checks that
log warnings or send fail ACKs. Affected handlers: cafe, distitem, data,
guild, guild_board, guild_cooking, guild_scout, house, mercenary, misc,
and rengoku. Also resolves all pre-existing lint issues: unchecked
bf.Seek in tests, unused filtered slice in svc_festa, unused mock
fields, and unused signserver test helper.
This commit is contained in:
Houmgaor
2026-02-27 11:33:25 +01:00
parent 4b24489ebe
commit 4e8c4b4e92
15 changed files with 236 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
server/channelserver/handlers_cafe.go
View File

@@ -51,7 +51,9 @@ func handleMsgMhfCheckDailyCafepoint(s *Session, p mhfpacket.MHFPacket) {
var bondBonus, bonusQuests, dailyQuests uint32
bf := byteframe.NewByteFrame()
if midday.After(dailyTime) {
_ = addPointNetcafe(s, 5)
if err := addPointNetcafe(s, 5); err != nil {
s.logger.Error("Failed to add daily netcafe points", zap.Error(err))
}
bondBonus = 5 // Bond point bonus quests
bonusQuests = s.server.erupeConfig.GameplayOptions.BonusQuestAllowance
dailyQuests = s.server.erupeConfig.GameplayOptions.DailyQuestAllowance
@@ -167,7 +169,9 @@ func handleMsgMhfPostCafeDurationBonusReceived(s *Session, p mhfpacket.MHFPacket
itemType, quantity, err := s.server.cafeRepo.GetBonusItem(cbID)
if err == nil {
if itemType == 17 {
_ = addPointNetcafe(s, int(quantity))
if err := addPointNetcafe(s, int(quantity)); err != nil {
s.logger.Error("Failed to add cafe bonus netcafe points", zap.Error(err))
}
}
}
if err := s.server.cafeRepo.AcceptBonus(cbID, s.charID); err != nil {
@@ -185,6 +189,7 @@ func addPointNetcafe(s *Session, p int) error {
points = min(points+p, s.server.erupeConfig.GameplayOptions.MaximumNP)
if err := s.server.charRepo.SaveInt(s.charID, "netcafe_points", points); err != nil {
s.logger.Error("Failed to update netcafe points", zap.Error(err))
return fmt.Errorf("save netcafe points: %w", err)
}
return nil
}