Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-27 18:12:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(channelserver): handle silently discarded errors across handlers

Browse Source 
Replace ~17 instances of '_ =' / '_ :=' with proper error checks that
log warnings or send fail ACKs. Affected handlers: cafe, distitem, data,
guild, guild_board, guild_cooking, guild_scout, house, mercenary, misc,
and rengoku. Also resolves all pre-existing lint issues: unchecked
bf.Seek in tests, unused filtered slice in svc_festa, unused mock
fields, and unused signserver test helper.
This commit is contained in:
Houmgaor
2026-02-27 11:33:25 +01:00
parent 4b24489ebe
commit 4e8c4b4e92
15 changed files with 236 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
server/channelserver/handlers_house.go
View File

@@ -43,7 +43,10 @@ func handleMsgMhfEnumerateHouse(s *Session, p mhfpacket.MHFPacket) {
var houses []HouseData
switch pkt.Method {
case 1:
friendsList, _ := s.server.charRepo.ReadString(s.charID, "friends")
friendsList, flErr := s.server.charRepo.ReadString(s.charID, "friends")
if flErr != nil {
s.logger.Warn("Failed to read friends list for house enumeration", zap.Error(flErr))
}
cids := stringsupport.CSVElems(friendsList)
for _, cid := range cids {
house, err := s.server.houseRepo.GetHouseByCharID(uint32(cid))
@@ -134,7 +137,10 @@ func handleMsgMhfLoadHouse(s *Session, p mhfpacket.MHFPacket) {
// Friends list verification
if state == 3 || state == 5 {
friendsList, _ := s.server.charRepo.ReadString(pkt.CharID, "friends")
friendsList, flErr := s.server.charRepo.ReadString(pkt.CharID, "friends")
if flErr != nil {
s.logger.Warn("Failed to read friends list for house access check", zap.Error(flErr))
}
cids := stringsupport.CSVElems(friendsList)
for _, cid := range cids {
if uint32(cid) == s.charID {
@@ -148,7 +154,10 @@ func handleMsgMhfLoadHouse(s *Session, p mhfpacket.MHFPacket) {
if state > 3 {
ownGuild, err := s.server.guildRepo.GetByCharID(s.charID)
if err == nil && ownGuild != nil {
isApplicant, _ := s.server.guildRepo.HasApplication(ownGuild.ID, s.charID)
isApplicant, appErr := s.server.guildRepo.HasApplication(ownGuild.ID, s.charID)
if appErr != nil {
s.logger.Warn("Failed to check guild application for house access", zap.Error(appErr))
}
othersGuild, err := s.server.guildRepo.GetByCharID(pkt.CharID)
if err == nil && othersGuild != nil {
if othersGuild.ID == ownGuild.ID && !isApplicant {