Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-27 18:12:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(channelserver): handle silently discarded errors across handlers

Browse Source 
Replace ~17 instances of '_ =' / '_ :=' with proper error checks that
log warnings or send fail ACKs. Affected handlers: cafe, distitem, data,
guild, guild_board, guild_cooking, guild_scout, house, mercenary, misc,
and rengoku. Also resolves all pre-existing lint issues: unchecked
bf.Seek in tests, unused filtered slice in svc_festa, unused mock
fields, and unused signserver test helper.
This commit is contained in:
Houmgaor
2026-02-27 11:33:25 +01:00
parent 4b24489ebe
commit 4e8c4b4e92
15 changed files with 236 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
server/channelserver/handlers_mercenary.go
View File

@@ -208,7 +208,10 @@ func handleMsgMhfReadMercenaryW(s *Session, p mhfpacket.MHFPacket) {
pkt := p.(*mhfpacket.MsgMhfReadMercenaryW)
bf := byteframe.NewByteFrame()
pactID, _ := readCharacterInt(s, "pact_id")
pactID, pactErr := readCharacterInt(s, "pact_id")
if pactErr != nil {
s.logger.Warn("Failed to read pact_id", zap.Error(pactErr))
}
var cid uint32
var name string
if pactID > 0 {
@@ -243,8 +246,14 @@ func handleMsgMhfReadMercenaryW(s *Session, p mhfpacket.MHFPacket) {
}
if pkt.Op != 1 && pkt.Op != 4 {
data, _ := s.server.charRepo.LoadColumn(s.charID, "savemercenary")
gcp, _ := readCharacterInt(s, "gcp")
data, dataErr := s.server.charRepo.LoadColumn(s.charID, "savemercenary")
if dataErr != nil {
s.logger.Warn("Failed to load savemercenary", zap.Error(dataErr))
}
gcp, gcpErr := readCharacterInt(s, "gcp")
if gcpErr != nil {
s.logger.Warn("Failed to read gcp", zap.Error(gcpErr))
}
if len(data) == 0 {
bf.WriteBool(false)
@@ -261,7 +270,10 @@ func handleMsgMhfReadMercenaryW(s *Session, p mhfpacket.MHFPacket) {
func handleMsgMhfReadMercenaryM(s *Session, p mhfpacket.MHFPacket) {
pkt := p.(*mhfpacket.MsgMhfReadMercenaryM)
data, _ := s.server.charRepo.LoadColumn(pkt.CharID, "savemercenary")
data, err := s.server.charRepo.LoadColumn(pkt.CharID, "savemercenary")
if err != nil {
s.logger.Warn("Failed to load savemercenary for other character", zap.Error(err))
}
resp := byteframe.NewByteFrame()
if len(data) == 0 {
resp.WriteBool(false)