mirror of
https://github.com/Mezeporta/Erupe.git
synced 2026-03-27 10:03:06 +01:00
fix(channelserver): handle silently discarded errors across handlers
Replace ~17 instances of '_ =' / '_ :=' with proper error checks that log warnings or send fail ACKs. Affected handlers: cafe, distitem, data, guild, guild_board, guild_cooking, guild_scout, house, mercenary, misc, and rengoku. Also resolves all pre-existing lint issues: unchecked bf.Seek in tests, unused filtered slice in svc_festa, unused mock fields, and unused signserver test helper.
This commit is contained in:
@@ -46,12 +46,11 @@ func (svc *FestaService) EnsureActiveEvent(currentStart uint32, now time.Time, n
|
||||
// SubmitSouls filters out zero-value soul entries and records the remaining
|
||||
// submissions for the character. Returns nil if all entries are zero.
|
||||
func (svc *FestaService) SubmitSouls(charID, guildID uint32, souls []uint16) error {
|
||||
var filtered []uint16
|
||||
hasNonZero := false
|
||||
for _, s := range souls {
|
||||
filtered = append(filtered, s)
|
||||
if s != 0 {
|
||||
hasNonZero = true
|
||||
break
|
||||
}
|
||||
}
|
||||
if !hasNonZero {
|
||||
|
||||
Reference in New Issue
Block a user