Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-22 07:32:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor(channelserver): standardize on BeginTxx for all repository transactions

Browse Source 
Replace db.Begin() with db.BeginTxx(context.Background(), nil) across all
8 remaining call sites in repo_guild.go, repo_guild_rp.go, repo_festa.go,
and repo_event.go. Use deferred Rollback() instead of explicit rollback
at each error return, eliminating 15 manual rollback calls.
This commit is contained in:
Houmgaor
2026-02-22 16:55:59 +01:00
parent 2acbb5d03a
commit 59fd722d37
5 changed files with 30 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
docs/technical-debt.md
View File

@@ -114,19 +114,9 @@ The pattern `m.Field, _ = stringsupport.SJISToUTF8(...)` appears across:
A malformed SJIS string from a client yields an empty string with no log output, making garbled text impossible to debug. The error return should at least be logged at debug level.
### 6. Inconsistent transaction API
### ~~6. Inconsistent transaction API~~ (Fixed)
`repo_guild.go` mixes two transaction styles in the same file:
```go
// Line 175 — no context, old style
tx, err := r.db.Begin()
// Line 518 — sqlx-idiomatic, with context
tx, err := r.db.BeginTxx(context.Background(), nil)
```
Should standardize on `BeginTxx` throughout. The `Begin()` calls cannot carry a context for cancellation or timeout.
**Status:** Fixed. All transaction call sites now use `BeginTxx(context.Background(), nil)` with deferred rollback, replacing the old `Begin()` + manual rollback pattern across `repo_guild.go`, `repo_guild_rp.go`, `repo_festa.go`, and `repo_event.go`.
### ~~7. `LoopDelay` config has no Viper default~~ (Fixed)
@@ -162,4 +152,4 @@ Based on impact and the momentum from recent repo-interface refactoring:
5. ~~**Fix `fmt.Sprintf` in logger calls**~~ — **Done**
6. ~~**Add `LoopDelay` Viper default**~~ — **Done**
7. **Log SJIS decoding errors** — improves debuggability for text issues
8. **Standardize on `BeginTxx`** — consistency fix in `repo_guild.go`
8. ~~**Standardize on `BeginTxx`**~~ — **Done**