refactor(config): eliminate ErupeConfig global variable

Replace the mutable global `_config.ErupeConfig` with dependency
injection across 79 files. Config is now threaded through existing
paths: `ClientContext.RealClientMode` for packet encoding, `s.server.
erupeConfig` for channel handlers, and explicit parameters for utility
functions. This removes hidden coupling, enables test parallelism
without global save/restore, and prevents low-level packages from
reaching up to the config layer.

Key changes:
- Enrich ClientContext with RealClientMode for packet files
- Add mode parameter to CryptConn, mhfitem, mhfcourse functions
- Convert handlers_commands init() to lazy sync.Once initialization
- Delete global var, init(), and helper functions from config.go
- Update all tests to pass config explicitly
This commit is contained in:
Houmgaor
2026-02-20 17:07:42 +01:00
parent 8c7e95ce18
commit 5f3c843082
79 changed files with 509 additions and 723 deletions

View File

@@ -94,14 +94,6 @@ func TestModeConstants(t *testing.T) {
}
}
// TestIsTestEnvironment tests the isTestEnvironment function
func TestIsTestEnvironment(t *testing.T) {
result := isTestEnvironment()
if !result {
t.Error("isTestEnvironment() should return true when running tests")
}
}
// TestVersionStringsLength verifies versionStrings has correct length
func TestVersionStringsLength(t *testing.T) {
expectedCount := 41 // S1 through ZZ = 41 versions
@@ -708,10 +700,3 @@ func BenchmarkGetOutboundIP4(b *testing.B) {
}
}
// BenchmarkIsTestEnvironment benchmarks test environment detection
func BenchmarkIsTestEnvironment(b *testing.B) {
b.ResetTimer()
for i := 0; i < b.N; i++ {
_ = isTestEnvironment()
}
}