Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-21 23:22:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(channelserver): return error from Save() to prevent misleading success logs

Browse Source 
CharacterSaveData.Save() silently returned on failure (nil decompressed
data, compression error, DB error) while the caller unconditionally
logged "Saved character data successfully". This made diagnosing save
failures difficult (ref #163).

Save() now returns an error, and all six call sites check it. The
success log in saveAllCharacterData only fires when the save actually
persisted.
This commit is contained in:
Houmgaor
2026-02-27 11:21:37 +01:00
parent 178a008e25
commit 74798fc8b3
7 changed files with 32 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
server/channelserver/handlers_character.go
View File

@@ -3,6 +3,7 @@ package channelserver
import (
"database/sql"
"errors"
"fmt"
cfg "erupe-ce/config"
"erupe-ce/network/mhfpacket"
@@ -46,12 +47,12 @@ func GetCharacterSaveData(s *Session, charID uint32) (*CharacterSaveData, error)
return saveData, nil
}
func (save *CharacterSaveData) Save(s *Session) {
func (save *CharacterSaveData) Save(s *Session) error {
if save.decompSave == nil {
s.logger.Warn("No decompressed save data, skipping save",
zap.Uint32("charID", save.CharID),
)
return
return errors.New("no decompressed save data")
}
if !s.kqfOverride {
@@ -66,7 +67,7 @@ func (save *CharacterSaveData) Save(s *Session) {
err := save.Compress()
if err != nil {
s.logger.Error("Failed to compress savedata", zap.Error(err))
return
return fmt.Errorf("compress savedata: %w", err)
}
} else {
// Saves were not compressed
@@ -75,11 +76,15 @@ func (save *CharacterSaveData) Save(s *Session) {
if err := s.server.charRepo.SaveCharacterData(save.CharID, save.compSave, save.HR, save.GR, save.Gender, save.WeaponType, save.WeaponID); err != nil {
s.logger.Error("Failed to update savedata", zap.Error(err), zap.Uint32("charID", save.CharID))
return fmt.Errorf("save character data: %w", err)
}
if err := s.server.charRepo.SaveHouseData(s.charID, save.HouseTier, save.HouseData, save.BookshelfData, save.GalleryData, save.ToreData, save.GardenData); err != nil {
s.logger.Error("Failed to update user binary house data", zap.Error(err))
return fmt.Errorf("save house data: %w", err)
}
return nil
}
func handleMsgMhfSexChanger(s *Session, p mhfpacket.MHFPacket) {