From 7dec7cbcef9ada3f8c0c584360d8d81882242001 Mon Sep 17 00:00:00 2001 From: Houmgaor Date: Mon, 23 Feb 2026 17:06:57 +0100 Subject: [PATCH] docs: mark all handler test gaps as resolved in tech debt tracker The 5 remaining handler files (seibattle, kouryou, scenario, distitem, guild_mission) were already covered by commit 6c0269d but the doc was not updated at the time. --- docs/technical-debt.md | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/docs/technical-debt.md b/docs/technical-debt.md index cbcf4693e..6d0a83eaf 100644 --- a/docs/technical-debt.md +++ b/docs/technical-debt.md @@ -35,15 +35,7 @@ These TODOs represent features that are visibly broken for players. ### 2. Test gaps on critical paths -**Handler files with no test file (5 remaining):** - -| File | Priority | Reason | -|------|----------|--------| -| `handlers_seibattle.go` | MEDIUM | Sei battle system | -| `handlers_scenario.go` | LOW | Mostly complete, uses repo | -| `handlers_distitem.go` | LOW | Distribution items | -| `handlers_guild_mission.go` | LOW | Guild missions | -| `handlers_kouryou.go` | LOW | Kouryou system | +**All handler files now have test coverage.** **Repository files with no store-level test file (17 total):** @@ -86,6 +78,7 @@ Items resolved since the original audit: | — | **Handler test coverage (4 files)** | Tests added for `handlers_session.go`, `handlers_gacha.go`, `handlers_plate.go`, `handlers_shop.go`. | | — | **Handler test coverage (`handlers_commands.go`)** | 62 tests covering all 12 commands, disabled-command gating, op overrides, error paths, raviente with semaphore, course enable/disable/locked, reload with players/objects. | | — | **Handler test coverage (`handlers_data_paper.go`)** | 20 tests covering all DataType branches (0/5/6/gift/>1000/unknown), ACK payload structure, earth succeed entry counts, timetable content, serialization round-trips, and paperGiftData table integrity. | +| — | **Handler test coverage (5 files)** | Tests added for `handlers_seibattle.go` (9 tests), `handlers_kouryou.go` (7 tests), `handlers_scenario.go` (6 tests), `handlers_distitem.go` (8 tests), `handlers_guild_mission.go` (5 tests in coverage5). | | — | **Entrance server raw SQL** | Refactored to repository interfaces (`repo_interfaces.go`, `repo_session.go`, `repo_server.go`). | | — | **Guild daily RP rollover** (`handlers_guild_ops.go:148`) | Implemented via lazy rollover in `handlers_guild.go:110-119` using `RolloverDailyRP()`. Stale TODO removed. | | — | **Typos** (`sys_session.go`, `handlers_session.go`) | "For Debuging" and "offical" typos already fixed in previous commits. |