From 7f13ee6a51f04fef1503c5b37569954757874998 Mon Sep 17 00:00:00 2001 From: Houmgaor Date: Mon, 23 Feb 2026 17:11:19 +0100 Subject: [PATCH] chore(mhfpacket): remove orphaned commented-out panics in stub parsers Replace dead `//panic("Not implemented")` after return statements with TODO comments indicating these are stub parsers with unknown fields. --- network/mhfpacket/msg_mhf_add_ud_point.go | 3 +-- network/mhfpacket/msg_mhf_set_kiju.go | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/network/mhfpacket/msg_mhf_add_ud_point.go b/network/mhfpacket/msg_mhf_add_ud_point.go index 3ccefa9ec..d07b796a1 100644 --- a/network/mhfpacket/msg_mhf_add_ud_point.go +++ b/network/mhfpacket/msg_mhf_add_ud_point.go @@ -25,9 +25,8 @@ func (m *MsgMhfAddUdPoint) Parse(bf *byteframe.ByteFrame, ctx *clientctx.ClientC m.AckHandle = bf.ReadUint32() m.Unk1 = bf.ReadUint32() m.Unk2 = bf.ReadUint32() - + // TODO: Parse is a stub — field meanings unknown return nil - //panic("Not implemented") } // Build builds a binary packet from the current data. diff --git a/network/mhfpacket/msg_mhf_set_kiju.go b/network/mhfpacket/msg_mhf_set_kiju.go index 24cc82101..a8cc70529 100644 --- a/network/mhfpacket/msg_mhf_set_kiju.go +++ b/network/mhfpacket/msg_mhf_set_kiju.go @@ -24,7 +24,6 @@ func (m *MsgMhfSetKiju) Parse(bf *byteframe.ByteFrame, ctx *clientctx.ClientCont m.AckHandle = bf.ReadUint32() m.Unk1 = bf.ReadUint16() return nil - //panic("Not implemented") } // Build builds a binary packet from the current data.