Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-29 03:52:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(achievement): fix test failures from migration 0008 side effects

Browse Source 
GetAllScores used SELECT * which broke when displayed_levels column was
added — now uses explicit column names. DisplayedAchievement handler
panicked on nil achievementService in empty-handler smoke tests — added
nil guard. Updated msg_build_test.go for renamed tactics point fields.
This commit is contained in:
Houmgaor
2026-03-18 12:14:31 +01:00
parent 792dcd5d91
commit 8785ebc21a
3 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
server/channelserver/handlers_achievement.go
View File

@@ -152,6 +152,9 @@ func handleMsgMhfAddAchievement(s *Session, p mhfpacket.MHFPacket) {
func handleMsgMhfPaymentAchievement(s *Session, p mhfpacket.MHFPacket) {}
func handleMsgMhfDisplayedAchievement(s *Session, p mhfpacket.MHFPacket) {
if s.server.achievementService == nil {
return
}
if err := s.server.achievementService.MarkDisplayed(s.charID); err != nil {
s.logger.Warn("Failed to mark achievements as displayed", zap.Error(err))
}