Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-28 10:32:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(channelserver): add error logging to silently ignored repo calls

Browse Source 
19 repository calls across 8 handler files were silently discarding
errors with `_ =`, making database failures invisible. Add structured
logging at appropriate levels: Error for write operations where data
loss may occur (guild saves, member updates), Warn for read operations
where handlers continue with zero-value defaults (application checks,
warehouse loads, item box queries). No control flow changes.
This commit is contained in:
Houmgaor
2026-02-21 17:37:29 +01:00
parent 6fbd294575
commit 8fe6f60813
8 changed files with 72 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/channelserver/handlers_guild_scout.go
View File

@@ -148,7 +148,9 @@ func handleMsgMhfAnswerGuildScout(s *Session, p mhfpacket.MHFPacket) {
bf.WriteUint32(guild.ID)
doAckBufSucceed(s, pkt.AckHandle, bf.Data())
for _, m := range msgs {
_ = s.server.mailRepo.SendMail(m.senderID, m.recipientID, m.subject, m.body, 0, 0, false, true)
if err := s.server.mailRepo.SendMail(m.senderID, m.recipientID, m.subject, m.body, 0, 0, false, true); err != nil {
s.logger.Warn("Failed to send guild scout response mail", zap.Error(err))
}
}
}
}