Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-22 07:32:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(tests): update packet field names after campaign RE renaming

Browse Source
This commit is contained in:
Houmgaor
2026-03-20 11:26:40 +01:00
parent 77e7969579
commit 90d9b7915a
3 changed files with 21 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
network/mhfpacket/msg_batch_parse_test.go
View File

@@ -420,7 +420,7 @@ func TestBatchParseMultiField(t *testing.T) {
if err := pkt.Parse(bf, ctx); err != nil { if err := pkt.Parse(bf, ctx); err != nil {
t.Fatal(err) t.Fatal(err)
} }
if pkt.Unk0 != 2 || pkt.Unk1 != 3 || pkt.Unk2 != 4 { if pkt.QuestID != 2 || pkt.ItemType != 3 || pkt.Quantity != 4 {
t.Error("field mismatch") t.Error("field mismatch")
} }
}) })

38
network/mhfpacket/msg_build_test.go
View File

@@ -515,8 +515,8 @@ func TestBuildParseStateCampaign(t *testing.T) {
if parsed.CampaignID != tt.campaignID { if parsed.CampaignID != tt.campaignID {
t.Errorf("CampaignID = %d, want %d", parsed.CampaignID, tt.campaignID) t.Errorf("CampaignID = %d, want %d", parsed.CampaignID, tt.campaignID)
} }
if parsed.Unk1 != tt.unk1 { if parsed.NullPadding != tt.unk1 {
t.Errorf("Unk1 = %d, want %d", parsed.Unk1, tt.unk1) t.Errorf("NullPadding = %d, want %d", parsed.NullPadding, tt.unk1)
} }
}) })
} }
@@ -526,15 +526,14 @@ func TestBuildParseStateCampaign(t *testing.T) {
// Build is NOT IMPLEMENTED, so we manually write the binary representation. // Build is NOT IMPLEMENTED, so we manually write the binary representation.
func TestBuildParseApplyCampaign(t *testing.T) { func TestBuildParseApplyCampaign(t *testing.T) {
tests := []struct { tests := []struct {
name string name string
ackHandle uint32 ackHandle uint32
unk0 uint32 campaignID uint32
unk1 uint16 code string
unk2 []byte
}{ }{
{"typical", 0x55667788, 5, 10, make([]byte, 16)}, {"typical", 0x55667788, 5, "TESTCODE"},
{"zero", 0, 0, 0, make([]byte, 16)}, {"zero", 0, 0, ""},
{"max", 0xFFFFFFFF, 0xFFFFFFFF, 0xFFFF, make([]byte, 16)}, {"max", 0xFFFFFFFF, 0xFFFFFFFF, "MAXCODE"},
} }
ctx := &clientctx.ClientContext{RealClientMode: cfg.ZZ} ctx := &clientctx.ClientContext{RealClientMode: cfg.ZZ}
@@ -542,9 +541,11 @@ func TestBuildParseApplyCampaign(t *testing.T) {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
bf := byteframe.NewByteFrame() bf := byteframe.NewByteFrame()
bf.WriteUint32(tt.ackHandle) bf.WriteUint32(tt.ackHandle)
bf.WriteUint32(tt.unk0) bf.WriteUint32(tt.campaignID)
bf.WriteUint16(tt.unk1) bf.WriteUint16(0) // zeroed
bf.WriteBytes(tt.unk2) codeBytes := make([]byte, 16)
copy(codeBytes, []byte(tt.code))
bf.WriteBytes(codeBytes)
_, _ = bf.Seek(0, io.SeekStart) _, _ = bf.Seek(0, io.SeekStart)
parsed := &MsgMhfApplyCampaign{} parsed := &MsgMhfApplyCampaign{}
@@ -555,14 +556,11 @@ func TestBuildParseApplyCampaign(t *testing.T) {
if parsed.AckHandle != tt.ackHandle { if parsed.AckHandle != tt.ackHandle {
t.Errorf("AckHandle = 0x%X, want 0x%X", parsed.AckHandle, tt.ackHandle) t.Errorf("AckHandle = 0x%X, want 0x%X", parsed.AckHandle, tt.ackHandle)
} }
if parsed.Unk0 != tt.unk0 { if parsed.CampaignID != tt.campaignID {
t.Errorf("Unk0 = %d, want %d", parsed.Unk0, tt.unk0) t.Errorf("CampaignID = %d, want %d", parsed.CampaignID, tt.campaignID)
} }
if parsed.Unk1 != tt.unk1 { if parsed.Code != tt.code {
t.Errorf("Unk1 = %d, want %d", parsed.Unk1, tt.unk1) t.Errorf("Code = %q, want %q", parsed.Code, tt.code)
}
if len(parsed.Unk2) != len(tt.unk2) {
t.Errorf("Unk2 len = %d, want %d", len(parsed.Unk2), len(tt.unk2))
} }
}) })
} }

4
network/mhfpacket/msg_parse_coverage_test.go
View File

@@ -102,8 +102,8 @@ func TestParseCoverage_VariableLength(t *testing.T) {
if err := pkt.Parse(parsed, ctx); err != nil { if err := pkt.Parse(parsed, ctx); err != nil {
t.Errorf("Parse() error: %v", err) t.Errorf("Parse() error: %v", err)
} }
if len(pkt.Unk1) != 2 { if len(pkt.RewardIDs) != 2 {
t.Errorf("expected 2 items, got %d", len(pkt.Unk1)) t.Errorf("expected 2 items, got %d", len(pkt.RewardIDs))
} }
}) })