Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-26 17:43:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(tests): fix three CI failures on develop

Browse Source 
- alliance recruiting default: change DEFAULT true → false in both
  0001_init.sql and 0004_alliance_recruiting.sql; new alliances should
  not be open for recruitment by default (TestSetAllianceRecruiting)
- guild_invites migration: add IF NOT EXISTS so re-running migrations
  on an existing DB does not fail with "relation already exists"
  (TestMigrateExistingDBWithoutSchemaVersion)
- test character name: shorten "Idem_Rollover_Leader" (19 chars) to
  "IdemRollLeader" to fit the VARCHAR(15) constraint
  (TestRolloverDailyRP_Idempotent)
This commit is contained in:
Houmgaor
2026-03-23 12:52:28 +01:00
parent 19a49fa0ae
commit 9e59ce69e3
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
server/channelserver/repo_guild_subsystems_test.go
View File

@@ -98,7 +98,7 @@ func TestRolloverDailyRP_Idempotent(t *testing.T) {
defer TeardownTestDB(t, db) defer TeardownTestDB(t, db)
userID := CreateTestUser(t, db, "idem_rollover_user") userID := CreateTestUser(t, db, "idem_rollover_user")
charID := CreateTestCharacter(t, db, userID, "Idem_Rollover_Leader") charID := CreateTestCharacter(t, db, userID, "IdemRollLeader")
guildID := CreateTestGuild(t, db, charID, "Idem_Rollover_Guild") guildID := CreateTestGuild(t, db, charID, "Idem_Rollover_Guild")
repo := NewGuildRepository(db) repo := NewGuildRepository(db)

2
server/migrations/sql/0001_init.sql
View File

@@ -998,7 +998,7 @@ CREATE TABLE public.guilds (
pugi_name_1 character varying(12) DEFAULT ''::character varying, pugi_name_1 character varying(12) DEFAULT ''::character varying,
pugi_name_2 character varying(12) DEFAULT ''::character varying, pugi_name_2 character varying(12) DEFAULT ''::character varying,
pugi_name_3 character varying(12) DEFAULT ''::character varying, pugi_name_3 character varying(12) DEFAULT ''::character varying,
recruiting boolean DEFAULT true NOT NULL, recruiting boolean DEFAULT false NOT NULL,
pugi_outfit_1 integer DEFAULT 0 NOT NULL, pugi_outfit_1 integer DEFAULT 0 NOT NULL,
pugi_outfit_2 integer DEFAULT 0 NOT NULL, pugi_outfit_2 integer DEFAULT 0 NOT NULL,
pugi_outfit_3 integer DEFAULT 0 NOT NULL, pugi_outfit_3 integer DEFAULT 0 NOT NULL,

2
server/migrations/sql/0004_alliance_recruiting.sql
View File

@@ -1 +1 @@
ALTER TABLE public.guild_alliances ADD COLUMN IF NOT EXISTS recruiting boolean NOT NULL DEFAULT true; ALTER TABLE public.guild_alliances ADD COLUMN IF NOT EXISTS recruiting boolean NOT NULL DEFAULT false;

2
server/migrations/sql/0012_guild_invites.sql
View File

@@ -2,7 +2,7 @@
-- player-initiated applications. This gives each invitation a real serial PK -- player-initiated applications. This gives each invitation a real serial PK
-- so the client's InvitationID field can map to an actual database row -- so the client's InvitationID field can map to an actual database row
-- instead of being aliased to the character ID. -- instead of being aliased to the character ID.
CREATE TABLE guild_invites ( CREATE TABLE IF NOT EXISTS guild_invites (
id serial PRIMARY KEY, id serial PRIMARY KEY,
guild_id integer REFERENCES guilds(id), guild_id integer REFERENCES guilds(id),
character_id integer REFERENCES characters(id), character_id integer REFERENCES characters(id),