Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-22 07:32:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(channelserver): send ACK on empty Raviente register payload

Browse Source 
handleMsgSysOperateRegister returned without sending an ACK when the
payload was empty, causing the client to softlock waiting for a response.
Send doAckBufSucceed with nil data on the early-return path to match
the success-path ACK type.

Also update tests to expect error returns instead of panics from
unimplemented Build/Parse stubs (matching prior panic→error refactor),
and mark resolved anti-patterns in docs.
This commit is contained in:
Houmgaor
2026-02-20 20:05:52 +01:00
parent ac59188488
commit a752c5187e
5 changed files with 21 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
network/binpacket/binpacket_test.go
View File

@@ -400,16 +400,13 @@ func TestMsgBinChatAllTypes(t *testing.T) {
}
}
func TestMsgBinMailNotifyParsePanics(t *testing.T) {
defer func() {
if r := recover(); r == nil {
t.Error("Parse() should panic with 'implement me'")
}
}()
func TestMsgBinMailNotifyParseReturnsError(t *testing.T) {
m := MsgBinMailNotify{}
bf := byteframe.NewByteFrame()
_ = m.Parse(bf)
err := m.Parse(bf)
if err == nil {
t.Error("Parse() should return an error (not implemented)")
}
}
func TestMsgBinMailNotifyBuildLongName(t *testing.T) {

16
network/binpacket/msg_bin_mail_notify_test.go
View File

@@ -102,19 +102,15 @@ func TestMsgBinMailNotify_Build(t *testing.T) {
}
}
func TestMsgBinMailNotify_Parse_Panics(t *testing.T) {
// Document that Parse() is not implemented and panics
func TestMsgBinMailNotify_Parse_ReturnsError(t *testing.T) {
// Document that Parse() is not implemented and returns an error
msg := MsgBinMailNotify{}
bf := byteframe.NewByteFrame()
defer func() {
if r := recover(); r == nil {
t.Error("Parse() did not panic, but should panic with 'implement me'")
}
}()
// This should panic
_ = msg.Parse(bf)
err := msg.Parse(bf)
if err == nil {
t.Error("Parse() should return an error (not implemented)")
}
}
func TestMsgBinMailNotify_BuildMultiple(t *testing.T) {