fix(channelserver): send ACK on empty Raviente register payload

handleMsgSysOperateRegister returned without sending an ACK when the
payload was empty, causing the client to softlock waiting for a response.
Send doAckBufSucceed with nil data on the early-return path to match
the success-path ACK type.

Also update tests to expect error returns instead of panics from
unimplemented Build/Parse stubs (matching prior panic→error refactor),
and mark resolved anti-patterns in docs.
This commit is contained in:
Houmgaor
2026-02-20 20:05:52 +01:00
parent ac59188488
commit a752c5187e
5 changed files with 21 additions and 29 deletions

View File

@@ -59,6 +59,7 @@ func handleMsgSysOperateRegister(s *Session, p mhfpacket.MHFPacket) {
pkt := p.(*mhfpacket.MsgSysOperateRegister)
if len(pkt.RawDataPayload) == 0 {
doAckBufSucceed(s, pkt.AckHandle, nil)
return
}