Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-26 09:33:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(handlers): fix softlock on forge purchases and N-points

Browse Source 
MSG_CA_EXCHANGE_ITEM and MSG_MHF_USE_UD_SHOP_COIN had Parse() returning
"NOT IMPLEMENTED". The dispatch loop in handlePacketGroup treats any
Parse error as a silent drop — no ACK is sent, causing the client to
wait indefinitely (softlock). Reported on 9.3.0-rc1 for forge item
purchases and Hunting Road N-point interactions.

Fix follows the pattern from d27da5e: parse only the AckHandle, return
nil from Parse, and respond with doAckBufFail so the client's error
branch exits cleanly without reading response fields.
This commit is contained in:
Houmgaor
2026-03-23 22:20:32 +01:00
parent 72088db4ff
commit abab6dc3a1
11 changed files with 33 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
server/channelserver/handlers_session.go
View File

@@ -752,7 +752,13 @@ func handleMsgMhfTransitMessage(s *Session, p mhfpacket.MHFPacket) {
doAckBufSucceed(s, pkt.AckHandle, resp.Data())
}
func handleMsgCaExchangeItem(s *Session, p mhfpacket.MHFPacket) {} // stub: unimplemented
func handleMsgCaExchangeItem(s *Session, p mhfpacket.MHFPacket) {
pkt := p.(*mhfpacket.MsgCaExchangeItem)
// TODO: full response format is not yet reverse-engineered.
// doAckBufFail sends a well-formed buf-type ACK with error code 1.
// The client's fail branch exits cleanly without reading response fields.
doAckBufFail(s, pkt.AckHandle, nil)
}
func handleMsgMhfServerCommand(s *Session, p mhfpacket.MHFPacket) {} // stub: unimplemented