mirror of
https://github.com/Mezeporta/Erupe.git
synced 2026-03-22 07:32:32 +01:00
refactor(channelserver): consolidate tests into matching source test files
Move ~300 test functions from 21 catch-all files (handlers_core_test.go, handlers_coverage*_test.go, *_coverage_test.go) into the *_test.go file matching each handler's source file. This makes tests discoverable by convention: tests for handlers_guild.go live in handlers_guild_test.go. New files: handlers_guild_mission_test.go, sys_time_test.go. No test logic changed — pure file reorganization.
This commit is contained in:
Houmgaor
@@ -824,6 +824,26 @@ func TestGuildAllianceRelationship(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// --- handleMsgMhfGetUdGuildMapInfo tests ---
|
||||
|
||||
func TestHandleMsgMhfGetUdGuildMapInfo(t *testing.T) {
|
||||
server := createMockServer()
|
||||
session := createMockSession(1, server)
|
||||
|
||||
handleMsgMhfGetUdGuildMapInfo(session, &mhfpacket.MsgMhfGetUdGuildMapInfo{
|
||||
AckHandle: 1,
|
||||
})
|
||||
|
||||
select {
|
||||
case p := <-session.sendPackets:
|
||||
if len(p.data) == 0 {
|
||||
t.Error("response should have data")
|
||||
}
|
||||
default:
|
||||
t.Error("no response queued")
|
||||
}
|
||||
}
|
||||
|
||||
// --- handleMsgMhfCheckMonthlyItem tests ---
|
||||
|
||||
func TestCheckMonthlyItem_NotClaimed(t *testing.T) {
|
||||
@@ -902,6 +922,156 @@ func TestCheckMonthlyItem_UnknownType(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfEntryRookieGuild(t *testing.T) {
|
||||
server := createMockServer()
|
||||
session := createMockSession(1, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfEntryRookieGuild{
|
||||
AckHandle: 12345,
|
||||
Unk: 42,
|
||||
}
|
||||
|
||||
handleMsgMhfEntryRookieGuild(session, pkt)
|
||||
|
||||
select {
|
||||
case p := <-session.sendPackets:
|
||||
if len(p.data) == 0 {
|
||||
t.Error("Response packet should have data")
|
||||
}
|
||||
default:
|
||||
t.Error("No response packet queued")
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfGenerateUdGuildMap(t *testing.T) {
|
||||
server := createMockServer()
|
||||
session := createMockSession(1, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfGenerateUdGuildMap{
|
||||
AckHandle: 12345,
|
||||
}
|
||||
|
||||
handleMsgMhfGenerateUdGuildMap(session, pkt)
|
||||
|
||||
select {
|
||||
case p := <-session.sendPackets:
|
||||
if len(p.data) == 0 {
|
||||
t.Error("Response packet should have data")
|
||||
}
|
||||
default:
|
||||
t.Error("No response packet queued")
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfEnumerateInvGuild(t *testing.T) {
|
||||
server := createMockServer()
|
||||
session := createMockSession(1, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfEnumerateInvGuild{
|
||||
AckHandle: 12345,
|
||||
}
|
||||
|
||||
handleMsgMhfEnumerateInvGuild(session, pkt)
|
||||
|
||||
select {
|
||||
case p := <-session.sendPackets:
|
||||
if len(p.data) == 0 {
|
||||
t.Error("Response packet should have data")
|
||||
}
|
||||
default:
|
||||
t.Error("No response packet queued")
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfOperationInvGuild(t *testing.T) {
|
||||
server := createMockServer()
|
||||
session := createMockSession(1, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfOperationInvGuild{
|
||||
AckHandle: 12345,
|
||||
Operation: 1,
|
||||
}
|
||||
|
||||
handleMsgMhfOperationInvGuild(session, pkt)
|
||||
|
||||
select {
|
||||
case p := <-session.sendPackets:
|
||||
if len(p.data) == 0 {
|
||||
t.Error("Response packet should have data")
|
||||
}
|
||||
default:
|
||||
t.Error("No response packet queued")
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfCheckMonthlyItem_Coverage2(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.stampRepo = &mockStampRepoForItems{monthlyClaimedErr: errNotFound}
|
||||
session := createMockSession(1, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfCheckMonthlyItem{
|
||||
AckHandle: 12345,
|
||||
Type: 0,
|
||||
}
|
||||
|
||||
handleMsgMhfCheckMonthlyItem(session, pkt)
|
||||
|
||||
select {
|
||||
case p := <-session.sendPackets:
|
||||
if len(p.data) == 0 {
|
||||
t.Error("Response packet should have data")
|
||||
}
|
||||
default:
|
||||
t.Error("No response packet queued")
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfAcquireMonthlyItem_Coverage2(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.stampRepo = &mockStampRepoForItems{}
|
||||
session := createMockSession(1, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfAcquireMonthlyItem{
|
||||
AckHandle: 12345,
|
||||
}
|
||||
|
||||
handleMsgMhfAcquireMonthlyItem(session, pkt)
|
||||
|
||||
select {
|
||||
case p := <-session.sendPackets:
|
||||
if len(p.data) == 0 {
|
||||
t.Error("Response packet should have data")
|
||||
}
|
||||
default:
|
||||
t.Error("No response packet queued")
|
||||
}
|
||||
}
|
||||
|
||||
func TestEmptyGuildHandlers(t *testing.T) {
|
||||
server := createMockServer()
|
||||
session := createMockSession(1, server)
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
handler func(s *Session, p mhfpacket.MHFPacket)
|
||||
}{
|
||||
{"handleMsgMhfUpdateForceGuildRank", handleMsgMhfUpdateForceGuildRank},
|
||||
{"handleMsgMhfUpdateGuild", handleMsgMhfUpdateGuild},
|
||||
{"handleMsgMhfUpdateGuildcard", handleMsgMhfUpdateGuildcard},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
defer func() {
|
||||
if r := recover(); r != nil {
|
||||
t.Errorf("%s panicked: %v", tt.name, r)
|
||||
}
|
||||
}()
|
||||
tt.handler(session, nil)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestAcquireMonthlyItem_MarksAsClaimed(t *testing.T) {
|
||||
server := createMockServer()
|
||||
stampMock := &mockStampRepoForItems{}
|
||||
@@ -924,3 +1094,242 @@ func TestAcquireMonthlyItem_MarksAsClaimed(t *testing.T) {
|
||||
t.Error("No response packet queued")
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfCreateGuild_Success(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.guildRepo = &mockGuildRepo{}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfCreateGuild{AckHandle: 1, Name: "TestGuild"}
|
||||
handleMsgMhfCreateGuild(session, pkt)
|
||||
|
||||
select {
|
||||
case p := <-session.sendPackets:
|
||||
if len(p.data) == 0 {
|
||||
t.Error("expected non-empty response")
|
||||
}
|
||||
default:
|
||||
t.Error("expected a response packet")
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfCreateGuild_Error(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.guildRepo = &mockGuildRepo{saveErr: errNotFound}
|
||||
// Mock Create to return error - the mockGuildRepo.Create returns (0, nil)
|
||||
// We need getErr to make it fail. Actually Create is a no-op stub returning nil.
|
||||
// Let's use a custom approach - we need the Create method to error.
|
||||
// The mock's Create always returns nil, so let's test the success path worked above
|
||||
// and test ArrangeGuildMember error paths instead.
|
||||
session := createMockSession(100, server)
|
||||
pkt := &mhfpacket.MsgMhfCreateGuild{AckHandle: 1, Name: "TestGuild"}
|
||||
handleMsgMhfCreateGuild(session, pkt)
|
||||
<-session.sendPackets // consume the response
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfArrangeGuildMember_Success(t *testing.T) {
|
||||
server := createMockServer()
|
||||
guild := &Guild{ID: 1, GuildLeader: GuildLeader{LeaderCharID: 100}}
|
||||
server.guildRepo = &mockGuildRepo{guild: guild}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfArrangeGuildMember{
|
||||
AckHandle: 1,
|
||||
GuildID: 1,
|
||||
CharIDs: []uint32{100, 200, 300},
|
||||
}
|
||||
handleMsgMhfArrangeGuildMember(session, pkt)
|
||||
|
||||
select {
|
||||
case <-session.sendPackets:
|
||||
default:
|
||||
t.Error("expected response")
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfArrangeGuildMember_GetByIDError(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.guildRepo = &mockGuildRepo{getErr: errNotFound}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfArrangeGuildMember{AckHandle: 1, GuildID: 999}
|
||||
handleMsgMhfArrangeGuildMember(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfArrangeGuildMember_NotLeader(t *testing.T) {
|
||||
server := createMockServer()
|
||||
guild := &Guild{ID: 1, GuildLeader: GuildLeader{LeaderCharID: 200, LeaderName: "Other"}}
|
||||
server.guildRepo = &mockGuildRepo{guild: guild}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfArrangeGuildMember{AckHandle: 1, GuildID: 1}
|
||||
handleMsgMhfArrangeGuildMember(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfEnumerateGuildMember_GuildIDPositive(t *testing.T) {
|
||||
server := createMockServer()
|
||||
guild := &Guild{ID: 1, MemberCount: 2}
|
||||
members := []*GuildMember{
|
||||
{CharID: 100, Name: "Player1", HR: 50, OrderIndex: 0, WeaponType: 3},
|
||||
{CharID: 200, Name: "Player2", HR: 100, OrderIndex: 1, WeaponType: 1},
|
||||
}
|
||||
server.guildRepo = &mockGuildRepo{guild: guild, members: members}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfEnumerateGuildMember{AckHandle: 1, GuildID: 1}
|
||||
handleMsgMhfEnumerateGuildMember(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfEnumerateGuildMember_GuildIDZero(t *testing.T) {
|
||||
server := createMockServer()
|
||||
guild := &Guild{ID: 1, MemberCount: 1}
|
||||
members := []*GuildMember{
|
||||
{CharID: 100, Name: "Player1", HR: 50, OrderIndex: 0},
|
||||
}
|
||||
server.guildRepo = &mockGuildRepo{guild: guild, members: members}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfEnumerateGuildMember{AckHandle: 1, GuildID: 0}
|
||||
handleMsgMhfEnumerateGuildMember(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfEnumerateGuildMember_NilGuild(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.guildRepo = &mockGuildRepo{}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfEnumerateGuildMember{AckHandle: 1, GuildID: 0}
|
||||
handleMsgMhfEnumerateGuildMember(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfEnumerateGuildMember_Applicant(t *testing.T) {
|
||||
server := createMockServer()
|
||||
guild := &Guild{ID: 1}
|
||||
server.guildRepo = &mockGuildRepo{guild: guild, hasAppResult: true}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfEnumerateGuildMember{AckHandle: 1, GuildID: 1}
|
||||
handleMsgMhfEnumerateGuildMember(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfGetGuildManageRight(t *testing.T) {
|
||||
server := createMockServer()
|
||||
guild := &Guild{ID: 1, MemberCount: 2}
|
||||
members := []*GuildMember{
|
||||
{CharID: 100, Recruiter: true},
|
||||
{CharID: 200, Recruiter: false},
|
||||
}
|
||||
server.guildRepo = &mockGuildRepo{guild: guild, members: members}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfGetGuildManageRight{AckHandle: 1}
|
||||
handleMsgMhfGetGuildManageRight(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfGetGuildTargetMemberNum_NilGuild(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.guildRepo = &mockGuildRepo{}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfGetGuildTargetMemberNum{AckHandle: 1, GuildID: 0}
|
||||
handleMsgMhfGetGuildTargetMemberNum(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfGetGuildTargetMemberNum_WithGuild(t *testing.T) {
|
||||
server := createMockServer()
|
||||
guild := &Guild{ID: 1, MemberCount: 5}
|
||||
server.guildRepo = &mockGuildRepo{guild: guild}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfGetGuildTargetMemberNum{AckHandle: 1, GuildID: 1}
|
||||
handleMsgMhfGetGuildTargetMemberNum(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfEnumerateGuildItem(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.guildRepo = &mockGuildRepo{}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfEnumerateGuildItem{AckHandle: 1, GuildID: 1}
|
||||
handleMsgMhfEnumerateGuildItem(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfUpdateGuildItem(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.guildRepo = &mockGuildRepo{}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfUpdateGuildItem{AckHandle: 1, GuildID: 1}
|
||||
handleMsgMhfUpdateGuildItem(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfUpdateGuildIcon_LeaderSuccess(t *testing.T) {
|
||||
server := createMockServer()
|
||||
guild := &Guild{ID: 1}
|
||||
membership := &GuildMember{CharID: 100, IsLeader: true}
|
||||
server.guildRepo = &mockGuildRepo{guild: guild, membership: membership}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfUpdateGuildIcon{
|
||||
AckHandle: 1,
|
||||
GuildID: 1,
|
||||
IconParts: []mhfpacket.GuildIconMsgPart{
|
||||
{Index: 0, ID: 1, Page: 0, Size: 10, Rotation: 0, Red: 255, Green: 0, Blue: 0, PosX: 50, PosY: 50},
|
||||
},
|
||||
}
|
||||
handleMsgMhfUpdateGuildIcon(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfUpdateGuildIcon_NotLeader(t *testing.T) {
|
||||
server := createMockServer()
|
||||
guild := &Guild{ID: 1}
|
||||
membership := &GuildMember{CharID: 100, IsLeader: false, OrderIndex: 5}
|
||||
server.guildRepo = &mockGuildRepo{guild: guild, membership: membership}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfUpdateGuildIcon{AckHandle: 1, GuildID: 1}
|
||||
handleMsgMhfUpdateGuildIcon(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfUpdateGuildIcon_GetByIDError(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.guildRepo = &mockGuildRepo{getErr: errNotFound}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfUpdateGuildIcon{AckHandle: 1, GuildID: 999}
|
||||
handleMsgMhfUpdateGuildIcon(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfReadGuildcard(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.guildRepo = &mockGuildRepo{}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfReadGuildcard{AckHandle: 1}
|
||||
handleMsgMhfReadGuildcard(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
func TestHandleMsgMhfSetGuildManageRight(t *testing.T) {
|
||||
server := createMockServer()
|
||||
server.guildRepo = &mockGuildRepo{}
|
||||
session := createMockSession(100, server)
|
||||
|
||||
pkt := &mhfpacket.MsgMhfSetGuildManageRight{AckHandle: 1, CharID: 200, Allowed: true}
|
||||
handleMsgMhfSetGuildManageRight(session, pkt)
|
||||
<-session.sendPackets
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user