Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-25 17:12:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

test(channelserver): replace time.Sleep with polling loops

Browse Source 
Blind sleeps accumulate serially (no t.Parallel anywhere) and inflate
under the race detector's scheduling overhead — contributing to the
~136s channelserver test run time.

Replace ~75 arbitrary sleeps (50ms–1s) across 7 test files with 2s
polling loops that exit as soon as the expected condition holds. Sleeps
that are genuinely intentional (race-condition stress tests, cache
expiry, temporal spacing in timestamp tests, backpressure pacing) are
left untouched.
This commit is contained in:
Houmgaor
2026-03-23 10:57:01 +01:00
parent 0c6dc39371
commit d0efc4e81a
8 changed files with 159 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
server/channelserver/savedata_lifecycle_monitoring_test.go
View File

@@ -155,13 +155,11 @@ func TestMonitored_SaveHandlerInvocationDuringLogout(t *testing.T) {
t.Log("Calling handleMsgMhfSavedata during session")
handleMsgMhfSavedata(session, savePkt)
monitor.RecordSavedata()
time.Sleep(100 * time.Millisecond)
// Now trigger logout
t.Log("Triggering logout - monitoring if save handlers are called")
monitor.RecordLogout()
logoutPlayer(session)
time.Sleep(100 * time.Millisecond)
// Report statistics
t.Log(monitor.GetStats())
@@ -233,12 +231,10 @@ func TestWithLogging_LogoutFlowAnalysis(t *testing.T) {
RawDataPayload: compressed,
}
handleMsgMhfSavedata(session, savePkt)
time.Sleep(50 * time.Millisecond)
// Trigger logout
t.Log("Triggering logout with logging enabled")
logoutPlayer(session)
time.Sleep(100 * time.Millisecond)
// Analyze logs
allLogs := logs.All()
@@ -317,11 +313,9 @@ func TestConcurrent_MultipleSessionsSaving(t *testing.T) {
RawDataPayload: compressed,
}
handleMsgMhfSavedata(session, savePkt)
time.Sleep(50 * time.Millisecond)
// Logout
logoutPlayer(session)
time.Sleep(50 * time.Millisecond)
// Verify data saved
var savedCompressed []byte
@@ -376,11 +370,9 @@ func TestSequential_RepeatedLogoutLoginCycles(t *testing.T) {
RawDataPayload: compressed,
}
handleMsgMhfSavedata(session, savePkt)
time.Sleep(50 * time.Millisecond)
// Logout
logoutPlayer(session)
time.Sleep(50 * time.Millisecond)
// Verify data after each cycle
var savedCompressed []byte
@@ -452,7 +444,6 @@ func TestRealtime_SaveDataTimestamps(t *testing.T) {
events = append(events, SaveEvent{time.Now(), "logout_start"})
logoutPlayer(session)
events = append(events, SaveEvent{time.Now(), "logout_end"})
time.Sleep(50 * time.Millisecond)
// Print timeline
t.Log("Save event timeline:")