Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-21 23:22:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(items): stop G-rank Workshop/Cog softlock on missing ACK

Browse Source 
MSG_MHF_GET_EXTRA_INFO (0xA6) and MSG_MHF_GET_COG_INFO (0xC3) had
Parse() returning NOT IMPLEMENTED. The dispatch loop treats any Parse
error as a hard drop — no ACK is ever sent, so the client waits
indefinitely and effectively soft-locks when entering the G-rank
Workshop or Master Felyne (Cog) screens.

Fix: parse AckHandle (the only field we can confirm from the protocol)
and respond with doAckBufFail so the client receives a well-formed
buf-type ACK with error code 1. The client's fail branch for these
requests exits cleanly without reading response fields, avoiding the
read-past-EOF crash that an empty success ACK would cause.

The full response format for both packets is still unknown; a complete
implementation requires further RE. The TODO comments mark the gap.

Fixes #180.
This commit is contained in:
Houmgaor
2026-03-19 14:35:38 +01:00
parent 7ea2660335
commit d27da5ec86
11 changed files with 60 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/unimplemented.md
View File

@@ -15,7 +15,7 @@ All empty handlers carry an inline comment — `// stub: unimplemented` for real
---
## Unimplemented (70 handlers)
## Unimplemented (68 handlers)
Grouped by handler file / game subsystem.
@@ -77,8 +77,6 @@ Grouped by handler file / game subsystem.
| Handler | Notes |
|---------|-------|
| `handleMsgMhfGetExtraInfo` | Fetch supplemental item/character info |
| `handleMsgMhfGetCogInfo` | Fetch Cog (partner Felyne) information |
| `handleMsgMhfStampcardPrize` | Claim a stamp card prize |
### Misc (`handlers_misc.go`)