mirror of
https://github.com/Mezeporta/Erupe.git
synced 2026-03-26 09:33:02 +01:00
fix(items): stop G-rank Workshop/Cog softlock on missing ACK
MSG_MHF_GET_EXTRA_INFO (0xA6) and MSG_MHF_GET_COG_INFO (0xC3) had Parse() returning NOT IMPLEMENTED. The dispatch loop treats any Parse error as a hard drop — no ACK is ever sent, so the client waits indefinitely and effectively soft-locks when entering the G-rank Workshop or Master Felyne (Cog) screens. Fix: parse AckHandle (the only field we can confirm from the protocol) and respond with doAckBufFail so the client receives a well-formed buf-type ACK with error code 1. The client's fail branch for these requests exits cleanly without reading response fields, avoiding the read-past-EOF crash that an empty success ACK would cause. The full response format for both packets is still unknown; a complete implementation requires further RE. The TODO comments mark the gap. Fixes #180.
This commit is contained in:
@@ -1079,7 +1079,6 @@ func TestEmptyHandlers_HandlersGo(t *testing.T) {
|
||||
{"handleMsgSysEnumuser", func() { handleMsgSysEnumuser(session, nil) }},
|
||||
{"handleMsgSysInfokyserver", func() { handleMsgSysInfokyserver(session, nil) }},
|
||||
{"handleMsgMhfGetCaUniqueID", func() { handleMsgMhfGetCaUniqueID(session, nil) }},
|
||||
{"handleMsgMhfGetExtraInfo", func() { handleMsgMhfGetExtraInfo(session, nil) }},
|
||||
{"handleMsgSysSetStatus", func() { handleMsgSysSetStatus(session, nil) }},
|
||||
{"handleMsgMhfStampcardPrize", func() { handleMsgMhfStampcardPrize(session, nil) }},
|
||||
{"handleMsgMhfKickExportForce", func() { handleMsgMhfKickExportForce(session, nil) }},
|
||||
@@ -1118,7 +1117,6 @@ func TestEmptyHandlers_Concurrent(t *testing.T) {
|
||||
handleMsgSysEnumuser,
|
||||
handleMsgSysInfokyserver,
|
||||
handleMsgMhfGetCaUniqueID,
|
||||
handleMsgMhfGetExtraInfo,
|
||||
handleMsgSysSetStatus,
|
||||
handleMsgSysDeleteObject,
|
||||
handleMsgSysRotateObject,
|
||||
|
||||
Reference in New Issue
Block a user