Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-29 12:02:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor(achievement): extract achievement logic into AchievementService

Browse Source 
Move EnsureExists + GetAllScores + compute loop from handler into
AchievementService.GetAll, and validation + ensure + increment into
AchievementService.Increment. Handlers now delegate to the service
layer for business logic while retaining protocol response building.

GetAchData stays as a pure function in handlers_achievement.go per plan.
This commit is contained in:
Houmgaor
2026-02-23 23:43:39 +01:00
parent bcdc4e0b7e
commit daacb76fb8
6 changed files with 262 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
server/channelserver/handlers_achievement_test.go
View File

@@ -461,6 +461,7 @@ func TestHandleMsgMhfGetAchievement_Success(t *testing.T) {
scores: [33]int32{5, 0, 20, 0, 0, 0, 0, 1}, // A few non-zero scores
}
server.achievementRepo = mock
ensureAchievementService(server)
session := createMockSession(1, server)
pkt := &mhfpacket.MsgMhfGetAchievement{
@@ -492,6 +493,7 @@ func TestHandleMsgMhfGetAchievement_DBError(t *testing.T) {
getScoresErr: errNotFound,
}
server.achievementRepo = mock
ensureAchievementService(server)
session := createMockSession(1, server)
pkt := &mhfpacket.MsgMhfGetAchievement{
@@ -516,6 +518,7 @@ func TestHandleMsgMhfGetAchievement_AllZeroScores(t *testing.T) {
server := createMockServer()
mock := &mockAchievementRepo{} // All scores default to 0
server.achievementRepo = mock
ensureAchievementService(server)
session := createMockSession(1, server)
pkt := &mhfpacket.MsgMhfGetAchievement{
@@ -539,6 +542,7 @@ func TestHandleMsgMhfAddAchievement_Valid(t *testing.T) {
server := createMockServer()
mock := &mockAchievementRepo{}
server.achievementRepo = mock
ensureAchievementService(server)
session := createMockSession(42, server)
pkt := &mhfpacket.MsgMhfAddAchievement{
@@ -559,6 +563,7 @@ func TestHandleMsgMhfAddAchievement_OutOfRange(t *testing.T) {
server := createMockServer()
mock := &mockAchievementRepo{}
server.achievementRepo = mock
ensureAchievementService(server)
session := createMockSession(42, server)
pkt := &mhfpacket.MsgMhfAddAchievement{
@@ -576,6 +581,7 @@ func TestHandleMsgMhfAddAchievement_BoundaryID32(t *testing.T) {
server := createMockServer()
mock := &mockAchievementRepo{}
server.achievementRepo = mock
ensureAchievementService(server)
session := createMockSession(42, server)
pkt := &mhfpacket.MsgMhfAddAchievement{