From e1aa863a1ff257c1257f1b907f7f640672a996e2 Mon Sep 17 00:00:00 2001 From: Houmgaor Date: Mon, 23 Mar 2026 11:06:50 +0100 Subject: [PATCH] test(channelserver): reduce polling interval from 10ms to 1ms MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit LoopDelay is 0 in test servers (bare struct, no Viper defaults), so sendLoop spins without delay and satisfies conditions in <1ms. The 10ms poll interval was the new bottleneck — dropping to 1ms cuts the channelserver test suite from ~136s to ~5s. --- server/channelserver/integration_test.go | 26 +++++++++---------- .../channelserver/sys_channel_server_test.go | 2 +- server/channelserver/sys_session_test.go | 20 +++++++------- 3 files changed, 24 insertions(+), 24 deletions(-) diff --git a/server/channelserver/integration_test.go b/server/channelserver/integration_test.go index 3b5746316..fb22c6e24 100644 --- a/server/channelserver/integration_test.go +++ b/server/channelserver/integration_test.go @@ -89,7 +89,7 @@ func IntegrationTest_PacketQueueFlow(t *testing.T) { if mock.PacketCount() >= tt.wantPackets { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets() @@ -186,7 +186,7 @@ done: if mock.PacketCount() >= expectedTotal { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets() @@ -255,7 +255,7 @@ func IntegrationTest_AckPacketFlow(t *testing.T) { if mock.PacketCount() >= ackCount { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets() @@ -330,7 +330,7 @@ func IntegrationTest_MixedPacketTypes(t *testing.T) { if mock.PacketCount() >= 4 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets() @@ -385,7 +385,7 @@ func IntegrationTest_PacketOrderPreservation(t *testing.T) { if mock.PacketCount() >= packetCount { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets() @@ -456,7 +456,7 @@ func IntegrationTest_QueueBackpressure(t *testing.T) { if mock.PacketCount() > 0 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } // Some packets should have been sent @@ -539,7 +539,7 @@ func IntegrationTest_GuildEnumerationFlow(t *testing.T) { if mock.PacketCount() >= tt.guildCount { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets() @@ -614,7 +614,7 @@ func IntegrationTest_ConcurrentClientAccess(t *testing.T) { if mock.PacketCount() >= tt.packetsPerClient { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } s.closed.Store(true) deadline = time.Now().Add(2 * time.Second) @@ -622,7 +622,7 @@ func IntegrationTest_ConcurrentClientAccess(t *testing.T) { if mock.PacketCount() >= tt.packetsPerClient { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentCount := mock.PacketCount() @@ -693,7 +693,7 @@ func IntegrationTest_ClientVersionCompatibility(t *testing.T) { if mock.PacketCount() >= 1 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } s.closed.Store(true) deadline = time.Now().Add(2 * time.Second) @@ -701,7 +701,7 @@ func IntegrationTest_ClientVersionCompatibility(t *testing.T) { if mock.PacketCount() >= 1 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentCount := mock.PacketCount() @@ -742,7 +742,7 @@ func IntegrationTest_PacketPrioritization(t *testing.T) { if mock.PacketCount() >= 10 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets() @@ -804,7 +804,7 @@ done: if mock.PacketCount() >= packetCount { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets() diff --git a/server/channelserver/sys_channel_server_test.go b/server/channelserver/sys_channel_server_test.go index 0b90d3a9d..f0a477d4f 100644 --- a/server/channelserver/sys_channel_server_test.go +++ b/server/channelserver/sys_channel_server_test.go @@ -291,7 +291,7 @@ func TestBroadcastMHFAllSessions(t *testing.T) { if receivedCount == sessionCount { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } // Stop all sessions diff --git a/server/channelserver/sys_session_test.go b/server/channelserver/sys_session_test.go index 270ff67b4..10b26bdcc 100644 --- a/server/channelserver/sys_session_test.go +++ b/server/channelserver/sys_session_test.go @@ -121,7 +121,7 @@ func TestPacketQueueIndividualSending(t *testing.T) { if mock.PacketCount() >= tt.wantPackets { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } // Stop the session @@ -131,7 +131,7 @@ func TestPacketQueueIndividualSending(t *testing.T) { if mock.PacketCount() >= tt.wantPackets { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } // Verify packet count @@ -182,7 +182,7 @@ func TestPacketQueueNoConcatenation(t *testing.T) { if mock.PacketCount() >= 3 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } s.closed.Store(true) deadline = time.Now().Add(2 * time.Second) @@ -190,7 +190,7 @@ func TestPacketQueueNoConcatenation(t *testing.T) { if mock.PacketCount() >= 3 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets() @@ -228,7 +228,7 @@ func TestQueueSendUsesQueue(t *testing.T) { s.QueueSend(testData) // Give it a moment - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) // WITHOUT sendLoop running, packets should NOT be sent yet if mock.PacketCount() > 0 { @@ -247,7 +247,7 @@ func TestQueueSendUsesQueue(t *testing.T) { if mock.PacketCount() >= 1 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } if mock.PacketCount() != 1 { @@ -272,7 +272,7 @@ func TestPacketTerminatorFormat(t *testing.T) { if mock.PacketCount() >= 1 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } s.closed.Store(true) deadline = time.Now().Add(2 * time.Second) @@ -280,7 +280,7 @@ func TestPacketTerminatorFormat(t *testing.T) { if mock.PacketCount() >= 1 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets() @@ -360,7 +360,7 @@ func TestPacketQueueAckFormat(t *testing.T) { if mock.PacketCount() >= 1 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } s.closed.Store(true) deadline = time.Now().Add(2 * time.Second) @@ -368,7 +368,7 @@ func TestPacketQueueAckFormat(t *testing.T) { if mock.PacketCount() >= 1 { break } - time.Sleep(10 * time.Millisecond) + time.Sleep(1 * time.Millisecond) } sentPackets := mock.GetSentPackets()