3 Commits

Author	SHA1	Message	Date
Houmgaor	a752c5187e	fix(channelserver): send ACK on empty Raviente register payload ... handleMsgSysOperateRegister returned without sending an ACK when the payload was empty, causing the client to softlock waiting for a response. Send doAckBufSucceed with nil data on the early-return path to match the success-path ACK type. Also update tests to expect error returns instead of panics from unimplemented Build/Parse stubs (matching prior panic→error refactor), and mark resolved anti-patterns in docs.	2026-02-20 20:05:52 +01:00
Houmgaor	bf983966a0	refactor(channelserver): migrate inline queries to helpers and define named constants ... Migrate 6 character data handlers to use the existing loadCharacterData and saveCharacterData helpers, eliminating duplicate inline SQL: - LoadFavoriteQuest, SaveFavoriteQuest, LoadDecoMyset, LoadMezfesData, LoadHunterNavi, GetEquipSkinHist Define named constants replacing magic numbers across handlers: - Achievement trophy tiers, broadcast/message types, diva phase durations, RP accrual rates, kill log layout, semaphore bases, quest stage/loading screen IDs Update anti-patterns doc with accurate line counts, evidence-based softlock analysis, and revised refactoring priorities.	2026-02-20 19:46:57 +01:00
Houmgaor	45c29837a5	docs: add codebase anti-patterns analysis ... Covers 13 identified anti-patterns across error handling, architecture, concurrency, and code organization with severity ratings and recommended refactoring priorities.	2026-02-20 18:46:06 +01:00