mirror of
https://github.com/Mezeporta/Erupe.git
synced 2026-03-21 23:22:34 +01:00
2abca9fb23
Extract business logic from handleMsgMhfOperateGuildMember into GuildService.OperateMember, establishing the handler→service→repo layering pattern. The handler is now ~20 lines of protocol glue (type-assert, map action, call service, send ACK, notify). GuildService owns authorization checks, repo coordination, mail composition, and best-effort mail delivery. It accepts plain Go types (no mhfpacket or Session imports), making it fully testable with mock repos. Cross-channel notification stays in the handler since it requires Session. Adds 7 table-driven service-level tests covering accept/reject/kick, authorization, repo errors, mail errors, and unknown actions.
78 lines
2.1 KiB
Go
78 lines
2.1 KiB
Go
package channelserver
|
|
|
|
import (
|
|
"net"
|
|
|
|
"erupe-ce/common/byteframe"
|
|
cfg "erupe-ce/config"
|
|
"erupe-ce/network"
|
|
"erupe-ce/network/clientctx"
|
|
|
|
"go.uber.org/zap"
|
|
)
|
|
|
|
// mockPacket implements mhfpacket.MHFPacket for testing.
|
|
// Imported from v9.2.x-stable.
|
|
type mockPacket struct {
|
|
opcode uint16
|
|
}
|
|
|
|
func (m *mockPacket) Opcode() network.PacketID {
|
|
return network.PacketID(m.opcode)
|
|
}
|
|
|
|
func (m *mockPacket) Build(bf *byteframe.ByteFrame, ctx *clientctx.ClientContext) error {
|
|
if ctx == nil {
|
|
panic("clientContext is nil")
|
|
}
|
|
bf.WriteUint32(0x12345678)
|
|
return nil
|
|
}
|
|
|
|
func (m *mockPacket) Parse(bf *byteframe.ByteFrame, ctx *clientctx.ClientContext) error {
|
|
return nil
|
|
}
|
|
|
|
// createMockServer creates a minimal Server for testing.
|
|
// Imported from v9.2.x-stable and adapted for main.
|
|
func createMockServer() *Server {
|
|
logger, _ := zap.NewDevelopment()
|
|
s := &Server{
|
|
logger: logger,
|
|
erupeConfig: &cfg.Config{},
|
|
// stages is a StageMap (zero value is ready to use)
|
|
sessions: make(map[net.Conn]*Session),
|
|
handlerTable: buildHandlerTable(),
|
|
raviente: &Raviente{
|
|
register: make([]uint32, 30),
|
|
state: make([]uint32, 30),
|
|
support: make([]uint32, 30),
|
|
},
|
|
}
|
|
s.i18n = getLangStrings(s)
|
|
s.Registry = NewLocalChannelRegistry([]*Server{s})
|
|
// GuildService is wired lazily by tests that set repos then call ensureGuildService.
|
|
return s
|
|
}
|
|
|
|
// ensureGuildService wires the GuildService from the server's current repos.
|
|
// Call this after setting guildRepo, mailRepo, and charRepo on the mock server.
|
|
func ensureGuildService(s *Server) {
|
|
s.guildService = NewGuildService(s.guildRepo, s.mailRepo, s.charRepo, s.logger)
|
|
}
|
|
|
|
// createMockSession creates a minimal Session for testing.
|
|
// Imported from v9.2.x-stable and adapted for main.
|
|
func createMockSession(charID uint32, server *Server) *Session {
|
|
logger, _ := zap.NewDevelopment()
|
|
return &Session{
|
|
charID: charID,
|
|
clientContext: &clientctx.ClientContext{},
|
|
sendPackets: make(chan packet, 20),
|
|
Name: "TestPlayer",
|
|
server: server,
|
|
logger: logger,
|
|
semaphoreID: make([]uint16, 2),
|
|
}
|
|
}
|