Houmgaor 2abca9fb23 refactor(guild): introduce service layer for guild member operations ...

Extract business logic from handleMsgMhfOperateGuildMember into
GuildService.OperateMember, establishing the handler→service→repo
layering pattern. The handler is now ~20 lines of protocol glue
(type-assert, map action, call service, send ACK, notify).

GuildService owns authorization checks, repo coordination, mail
composition, and best-effort mail delivery. It accepts plain Go
types (no mhfpacket or Session imports), making it fully testable
with mock repos. Cross-channel notification stays in the handler
since it requires Session.

Adds 7 table-driven service-level tests covering accept/reject/kick,
authorization, repo errors, mail errors, and unknown actions.

2026-02-23 23:26:46 +01:00

..

compression

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

channel_isolation_test.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

channel_registry_local.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

channel_registry_test.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

channel_registry.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

client_connection_simulation_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

constants_quest.go

…

constants_raviente.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

constants_time.go

…

doc.go

docs: expand doc.go for channelserver and mhfpacket packages

2026-02-23 18:09:08 +01:00

guild_model.go

…

handlers_achievement_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_achievement.go

…

handlers_bbs_test.go

…

handlers_bbs.go

…

handlers_cafe_test.go

test(channelserver): add mock-based handler unit tests

2026-02-21 14:01:52 +01:00

handlers_cafe.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_campaign_test.go

…

handlers_campaign.go

…

handlers_caravan_test.go

…

handlers_caravan.go

…

handlers_cast_binary_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_cast_binary.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_character_test.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

handlers_character.go

refactor(channelserver): move remaining s.server.db calls into repositories

2026-02-21 14:08:01 +01:00

handlers_clients_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_clients.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

handlers_commands_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_commands.go

refactor: replace raw SQL with repository interfaces in entranceserver and API server

2026-02-22 17:04:58 +01:00

handlers_core_test.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

handlers_coverage2_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_coverage3_test.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

handlers_coverage4_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_coverage5_test.go

…

handlers_coverage_test.go

…

handlers_data_extended_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_data_paper_tables.go

refactor(channelserver): move paper data tables out of handler function

2026-02-23 18:24:54 +01:00

handlers_data_paper_test.go

test(channelserver): add unit tests for paper data handler

2026-02-23 17:01:20 +01:00

handlers_data_paper.go

refactor(channelserver): move paper data tables out of handler function

2026-02-23 18:24:54 +01:00

handlers_data_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_data.go

fix: log SJIS decoding errors instead of silently discarding them

2026-02-22 17:01:22 +01:00

handlers_discord_test.go

…

handlers_discord.go

…

handlers_distitem_test.go

test(channelserver): add unit tests for helpers, kouryou, scenario, seibattle, and distitem handlers

2026-02-22 18:55:31 +01:00

handlers_distitem.go

…

handlers_diva_test.go

…

handlers_diva.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_event_test.go

…

handlers_event.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_festa_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_festa.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_gacha_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_gacha.go

…

handlers_goocoo_test.go

test(channelserver): add mock-based handler unit tests

2026-02-21 14:01:52 +01:00

handlers_goocoo.go

…

handlers_guild_adventure_test.go

test(channelserver): add handler tests for guild info, alliance, cooking, adventure, and treasure

2026-02-21 18:10:19 +01:00

handlers_guild_adventure.go

…

handlers_guild_alliance_test.go

test(channelserver): add handler tests for guild info, alliance, cooking, adventure, and treasure

2026-02-21 18:10:19 +01:00

handlers_guild_alliance.go

…

handlers_guild_board_test.go

test(channelserver): add handler tests for guild ops, scout, board, and items

2026-02-21 17:58:08 +01:00

handlers_guild_board.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_guild_cooking_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_guild_cooking.go

…

handlers_guild_icon_test.go

…

handlers_guild_info_test.go

test(channelserver): add handler tests for guild info, alliance, cooking, adventure, and treasure

2026-02-21 18:10:19 +01:00

handlers_guild_info.go

fix: log SJIS decoding errors instead of silently discarding them

2026-02-22 17:01:22 +01:00

handlers_guild_member_test.go

…

handlers_guild_member.go

…

handlers_guild_mission.go

…

handlers_guild_ops_test.go

refactor(guild): introduce service layer for guild member operations

2026-02-23 23:26:46 +01:00

handlers_guild_ops.go

refactor(guild): introduce service layer for guild member operations

2026-02-23 23:26:46 +01:00

handlers_guild_scout_test.go

test(channelserver): add handler tests for guild ops, scout, board, and items

2026-02-21 17:58:08 +01:00

handlers_guild_scout.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_guild_test.go

feat(channelserver): implement monthly guild item claim tracking

2026-02-22 16:46:57 +01:00

handlers_guild_tresure_test.go

test(channelserver): add handler tests for guild info, alliance, cooking, adventure, and treasure

2026-02-21 18:10:19 +01:00

handlers_guild_tresure.go

…

handlers_guild.go

feat(channelserver): implement monthly guild item claim tracking

2026-02-22 16:46:57 +01:00

handlers_helpers_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_helpers.go

…

handlers_house_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_house.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_items_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_items.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_kouryou_test.go

test(channelserver): add unit tests for helpers, kouryou, scenario, seibattle, and distitem handlers

2026-02-22 18:55:31 +01:00

handlers_kouryou.go

…

handlers_mail_test.go

test(channelserver): add mock-based handler unit tests

2026-02-21 14:01:52 +01:00

handlers_mail.go

…

handlers_mercenary_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_mercenary.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_misc_test.go

…

handlers_misc.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_mutex_test.go

…

handlers_mutex.go

…

handlers_object_test.go

…

handlers_object.go

…

handlers_plate_test.go

test(channelserver): add handler tests for session, gacha, shop, and plate

2026-02-22 16:05:25 +01:00

handlers_plate.go

…

handlers_quest_backport_test.go

…

handlers_quest_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_quest.go

fix: replace fmt.Sprintf in logger calls with structured fields and add LoopDelay default

2026-02-22 16:32:43 +01:00

handlers_register_test.go

…

handlers_register.go

…

handlers_rengoku_integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_rengoku_test.go

…

handlers_rengoku.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_reserve_test.go

…

handlers_reserve.go

…

handlers_reward_test.go

…

handlers_reward.go

…

handlers_savedata_integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_scenario_test.go

test(channelserver): add unit tests for helpers, kouryou, scenario, seibattle, and distitem handlers

2026-02-22 18:55:31 +01:00

handlers_scenario.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_seibattle_test.go

test(channelserver): add unit tests for helpers, kouryou, scenario, seibattle, and distitem handlers

2026-02-22 18:55:31 +01:00

handlers_seibattle.go

…

handlers_semaphore_test.go

…

handlers_semaphore.go

…

handlers_session_test.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

handlers_session.go

feat(pcap): complete replay system with filtering, metadata, and live replay

2026-02-23 19:34:30 +01:00

handlers_shop_gacha_test.go

…

handlers_shop_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_shop.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_simple_test.go

…

handlers_stage_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_stage.go

refactor: replace raw SQL with repository interfaces in entranceserver and API server

2026-02-22 17:04:58 +01:00

handlers_table.go

…

handlers_tactics_test.go

…

handlers_tactics.go

…

handlers_test.go

…

handlers_tournament_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_tournament.go

…

handlers_tower_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_tower.go

…

handlers_users_test.go

…

handlers_users.go

…

handlers_util_test.go

…

integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

minidata_store_test.go

test(channelserver): add store tests and document lock ordering

2026-02-21 13:56:46 +01:00

minidata_store.go

…

model_character.go

fix: log SJIS decoding errors instead of silently discarding them

2026-02-22 17:01:22 +01:00

quest_cache_test.go

test(channelserver): add store tests and document lock ordering

2026-02-21 13:56:46 +01:00

quest_cache.go

…

raviente.go

…

repo_achievement.go

…

repo_cafe.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

repo_character_test.go

test(channelserver): add store tests for new repository methods

2026-02-21 14:21:32 +01:00

repo_character.go

refactor(channelserver): move remaining s.server.db calls into repositories

2026-02-21 14:08:01 +01:00

repo_distribution.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_diva.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

repo_event_test.go

refactor(channelserver): eliminate *sql.Tx from repository interfaces

2026-02-21 14:56:59 +01:00

repo_event.go

refactor(channelserver): standardize on BeginTxx for all repository transactions

2026-02-22 16:55:59 +01:00

repo_festa.go

refactor(channelserver): standardize on BeginTxx for all repository transactions

2026-02-22 16:55:59 +01:00

repo_gacha.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_goocoo.go

…

repo_guild_adventure.go

refactor(channelserver): split repo_guild.go into domain-focused files

2026-02-22 16:42:03 +01:00

repo_guild_alliance.go

refactor(channelserver): split repo_guild.go into domain-focused files

2026-02-22 16:42:03 +01:00

repo_guild_cooking.go

refactor(channelserver): split repo_guild.go into domain-focused files

2026-02-22 16:42:03 +01:00

repo_guild_hunt.go

refactor(channelserver): split repo_guild.go into domain-focused files

2026-02-22 16:42:03 +01:00

repo_guild_posts.go

refactor(channelserver): split repo_guild.go into domain-focused files

2026-02-22 16:42:03 +01:00

repo_guild_rp.go

refactor(channelserver): standardize on BeginTxx for all repository transactions

2026-02-22 16:55:59 +01:00

repo_guild_test.go

refactor(channelserver): eliminate *sql.Tx from repository interfaces

2026-02-21 14:56:59 +01:00

repo_guild.go

refactor(channelserver): standardize on BeginTxx for all repository transactions

2026-02-22 16:55:59 +01:00

repo_house.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_interfaces.go

feat(channelserver): implement monthly guild item claim tracking

2026-02-22 16:46:57 +01:00

repo_mail.go

refactor(channelserver): eliminate *sql.Tx from repository interfaces

2026-02-21 14:56:59 +01:00

repo_mercenary.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_misc.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_mocks_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

repo_rengoku.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

repo_scenario.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_session.go

…

repo_shop.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

repo_stamp.go

feat(channelserver): implement monthly guild item claim tracking

2026-02-22 16:46:57 +01:00

repo_tower.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_user_test.go

test(channelserver): add store tests for new repository methods

2026-02-21 14:21:32 +01:00

repo_user.go

refactor(channelserver): move remaining s.server.db calls into repositories

2026-02-21 14:08:01 +01:00

savedata_lifecycle_monitoring_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

session_lifecycle_integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

svc_guild_test.go

refactor(guild): introduce service layer for guild member operations

2026-02-23 23:26:46 +01:00

svc_guild.go

refactor(guild): introduce service layer for guild member operations

2026-02-23 23:26:46 +01:00

sys_capture.go

feat(pcap): complete replay system with filtering, metadata, and live replay

2026-02-23 19:34:30 +01:00

sys_channel_server_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_channel_server.go

refactor(guild): introduce service layer for guild member operations

2026-02-23 23:26:46 +01:00

sys_language_test.go

…

sys_language.go

…

sys_object_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_semaphore_test.go

…

sys_semaphore.go

…

sys_session_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_session.go

feat(pcap): complete replay system with filtering, metadata, and live replay

2026-02-23 19:34:30 +01:00

sys_stage_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_stage.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

sys_time.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

test_helpers_test.go

refactor(guild): introduce service layer for guild member operations

2026-02-23 23:26:46 +01:00

testhelpers_db.go

feat(config): register all defaults in code, shrink example config

2026-02-23 21:25:44 +01:00

user_binary_store_test.go

test(channelserver): add store tests and document lock ordering

2026-02-21 13:56:46 +01:00

user_binary_store.go

…