Houmgaor 74798fc8b3 fix(channelserver): return error from Save() to prevent misleading success logs ...

CharacterSaveData.Save() silently returned on failure (nil decompressed
data, compression error, DB error) while the caller unconditionally
logged "Saved character data successfully". This made diagnosing save
failures difficult (ref #163).

Save() now returns an error, and all six call sites check it. The
success log in saveAllCharacterData only fires when the save actually
persisted.

2026-02-27 11:21:37 +01:00

..

compression

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

channel_isolation_test.go

…

channel_registry_local.go

…

channel_registry_test.go

…

channel_registry.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

client_connection_simulation_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

constants_quest.go

…

constants_raviente.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

constants_time.go

…

doc.go

docs: expand doc.go for channelserver and mhfpacket packages

2026-02-23 18:09:08 +01:00

guild_model.go

…

handlers_achievement_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_achievement.go

refactor(achievement): extract achievement logic into AchievementService

2026-02-23 23:43:39 +01:00

handlers_bbs_test.go

…

handlers_bbs.go

…

handlers_cafe_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_cafe.go

…

handlers_campaign_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_campaign.go

…

handlers_caravan_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_caravan.go

…

handlers_cast_binary_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_cast_binary.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_character_test.go

fix(channelserver): return error from Save() to prevent misleading success logs

2026-02-27 11:21:37 +01:00

handlers_character.go

fix(channelserver): return error from Save() to prevent misleading success logs

2026-02-27 11:21:37 +01:00

handlers_clients_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_clients.go

…

handlers_commands_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_commands.go

fix(commands): validate argument parsing in chat commands

2026-02-24 13:57:58 +01:00

handlers_data_extended_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_data_paper_tables.go

refactor(channelserver): move paper data tables out of handler function

2026-02-23 18:24:54 +01:00

handlers_data_paper_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_data_paper.go

refactor(channelserver): move paper data tables out of handler function

2026-02-23 18:24:54 +01:00

handlers_data_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_data.go

fix(channelserver): return error from Save() to prevent misleading success logs

2026-02-27 11:21:37 +01:00

handlers_discord_test.go

…

handlers_discord.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_distitem_test.go

…

handlers_distitem.go

fix(channelserver): return error from Save() to prevent misleading success logs

2026-02-27 11:21:37 +01:00

handlers_diva_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_diva.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_event_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_event.go

…

handlers_festa_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_festa.go

refactor(festa): extract festa logic into FestaService

2026-02-24 16:12:40 +01:00

handlers_gacha_test.go

refactor(gacha): extract gacha logic into GachaService

2026-02-23 23:57:54 +01:00

handlers_gacha.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_goocoo_test.go

…

handlers_goocoo.go

…

handlers_guild_adventure_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

handlers_guild_adventure.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_guild_alliance_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

handlers_guild_alliance.go

…

handlers_guild_board_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_guild_board.go

…

handlers_guild_cooking_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

handlers_guild_cooking.go

…

handlers_guild_icon_test.go

…

handlers_guild_info_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

handlers_guild_info.go

…

handlers_guild_member_test.go

…

handlers_guild_member.go

…

handlers_guild_mission_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_guild_mission.go

…

handlers_guild_ops_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_guild_ops.go

fix(channelserver): return error from Save() to prevent misleading success logs

2026-02-27 11:21:37 +01:00

handlers_guild_scout_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

handlers_guild_scout.go

refactor(guild): extract disband, resign, leave, and scout logic into GuildService

2026-02-23 23:35:28 +01:00

handlers_guild_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_guild_tresure_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_guild_tresure.go

…

handlers_guild.go

…

handlers_helpers_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_helpers.go

…

handlers_house_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_house.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_items_tables.go

refactor(items): extract inline data tables from handleMsgMhfEnumeratePrice

2026-02-24 15:34:51 +01:00

handlers_items_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_items.go

refactor(items): extract inline data tables from handleMsgMhfEnumeratePrice

2026-02-24 15:34:51 +01:00

handlers_kouryou_test.go

…

handlers_kouryou.go

…

handlers_mail_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

handlers_mail.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

handlers_mercenary_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_mercenary.go

…

handlers_misc_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_misc.go

…

handlers_mutex_test.go

…

handlers_mutex.go

…

handlers_object_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_object.go

…

handlers_plate_test.go

…

handlers_plate.go

…

handlers_quest_backport_test.go

…

handlers_quest_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_quest.go

…

handlers_register_test.go

…

handlers_register.go

…

handlers_rengoku_integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_rengoku_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_rengoku.go

…

handlers_reserve_test.go

…

handlers_reserve.go

…

handlers_reward_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_reward.go

…

handlers_savedata_integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_scenario_test.go

…

handlers_scenario.go

…

handlers_seibattle_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_seibattle.go

…

handlers_semaphore_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_semaphore.go

…

handlers_session_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_session.go

fix(channelserver): return error from Save() to prevent misleading success logs

2026-02-27 11:21:37 +01:00

handlers_shop_gacha_test.go

…

handlers_shop_test.go

fix(shop): update early return test to use pre-G1 client version

2026-02-26 21:57:40 +01:00

handlers_shop.go

fix(shop): write gacha header for G1+ clients, not just GG+

2026-02-26 23:53:35 +01:00

handlers_simple_test.go

…

handlers_stage_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_stage.go

…

handlers_table.go

…

handlers_tactics_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_tactics.go

…

handlers_test.go

…

handlers_tournament_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_tournament.go

…

handlers_tower_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_tower.go

fix(channelserver): return error from Save() to prevent misleading success logs

2026-02-27 11:21:37 +01:00

handlers_users_test.go

…

handlers_users.go

…

handlers_util_test.go

…

integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

minidata_store_test.go

…

minidata_store.go

…

model_character.go

…

quest_cache_test.go

…

quest_cache.go

…

raviente.go

…

repo_achievement_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_achievement.go

…

repo_cafe_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_cafe.go

…

repo_character_test.go

…

repo_character.go

…

repo_distribution_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_distribution.go

…

repo_diva_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_diva.go

…

repo_event_test.go

…

repo_event.go

…

repo_festa_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_festa.go

refactor(festa): extract festa logic into FestaService

2026-02-24 16:12:40 +01:00

repo_gacha_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_gacha.go

…

repo_goocoo_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_goocoo.go

…

repo_guild_adventure.go

…

repo_guild_alliance.go

…

repo_guild_cooking.go

…

repo_guild_hunt.go

…

repo_guild_posts.go

…

repo_guild_rp.go

…

repo_guild_test.go

…

repo_guild.go

…

repo_house_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_house.go

…

repo_interfaces.go

refactor(tower): extract tower logic into TowerService

2026-02-24 16:07:37 +01:00

repo_mail_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_mail.go

…

repo_mercenary_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_mercenary.go

…

repo_misc_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_misc.go

…

repo_mocks_test.go

test(channelserver): add handler coverage tests for misc, cafe, festa, event

2026-02-26 22:28:32 +01:00

repo_rengoku_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_rengoku.go

…

repo_scenario_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_scenario.go

…

repo_session_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_session.go

…

repo_shop_test.go

fix(shop): resolve ambiguous column and missing unique constraint in RecordPurchase

2026-02-24 17:06:38 +01:00

repo_shop.go

fix(shop): resolve ambiguous column and missing unique constraint in RecordPurchase

2026-02-24 17:06:38 +01:00

repo_stamp_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_stamp.go

…

repo_tower_test.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

repo_tower.go

refactor(tower): extract tower logic into TowerService

2026-02-24 16:07:37 +01:00

repo_user_test.go

…

repo_user.go

…

savedata_lifecycle_monitoring_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

session_lifecycle_integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

svc_achievement_test.go

refactor(achievement): extract achievement logic into AchievementService

2026-02-23 23:43:39 +01:00

svc_achievement.go

refactor(achievement): extract achievement logic into AchievementService

2026-02-23 23:43:39 +01:00

svc_festa_test.go

refactor(festa): extract festa logic into FestaService

2026-02-24 16:12:40 +01:00

svc_festa.go

refactor(festa): extract festa logic into FestaService

2026-02-24 16:12:40 +01:00

svc_gacha_test.go

refactor(gacha): extract gacha logic into GachaService

2026-02-23 23:57:54 +01:00

svc_gacha.go

refactor(gacha): extract gacha logic into GachaService

2026-02-23 23:57:54 +01:00

svc_guild_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

svc_guild.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

svc_mail_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

svc_mail.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

svc_tower_test.go

refactor(tower): extract tower logic into TowerService

2026-02-24 16:07:37 +01:00

svc_tower.go

refactor(tower): extract tower logic into TowerService

2026-02-24 16:07:37 +01:00

sys_capture.go

feat(pcap): complete replay system with filtering, metadata, and live replay

2026-02-23 19:34:30 +01:00

sys_channel_server_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_channel_server.go

refactor(festa): extract festa logic into FestaService

2026-02-24 16:12:40 +01:00

sys_language_test.go

…

sys_language.go

…

sys_object_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_semaphore_test.go

…

sys_semaphore.go

…

sys_session_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_session.go

feat(pcap): complete replay system with filtering, metadata, and live replay

2026-02-23 19:34:30 +01:00

sys_stage_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_stage.go

…

sys_time_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

sys_time.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

test_helpers_test.go

refactor(festa): extract festa logic into FestaService

2026-02-24 16:12:40 +01:00

testhelpers_db.go

test(repos): add SQL integration tests for 17 untested repo files

2026-02-24 16:57:47 +01:00

user_binary_store_test.go

…

user_binary_store.go

…