Houmgaor 8fead0b1f3 fix(handlers): add error handling for swallowed repo/service errors ...

Several handler files discarded errors from repository and service
calls, creating nil-dereference risks and silent data corruption:

- guild_adventure: 3 GetByCharID calls could panic on nil guild
- gacha: GetGachaPoints silently returned zero balances on DB error
- house: HasApplication called before nil check on guild;
  GetHouseContents error discarded with 7 return values
- distitem: 3 distRepo calls had no error logging
- guild_ops: Disband/Leave service errors were invisible
- shop: gacha type/weight/fpoint lookups had no error logging
- discord: bcrypt error could result in nil password being set

2026-02-24 13:55:49 +01:00

..

compression

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

channel_isolation_test.go

…

channel_registry_local.go

…

channel_registry_test.go

…

channel_registry.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

client_connection_simulation_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

constants_quest.go

…

constants_raviente.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

constants_time.go

…

doc.go

docs: expand doc.go for channelserver and mhfpacket packages

2026-02-23 18:09:08 +01:00

guild_model.go

…

handlers_achievement_test.go

refactor(achievement): extract achievement logic into AchievementService

2026-02-23 23:43:39 +01:00

handlers_achievement.go

refactor(achievement): extract achievement logic into AchievementService

2026-02-23 23:43:39 +01:00

handlers_bbs_test.go

…

handlers_bbs.go

…

handlers_cafe_test.go

…

handlers_cafe.go

…

handlers_campaign_test.go

…

handlers_campaign.go

…

handlers_caravan_test.go

…

handlers_caravan.go

…

handlers_cast_binary_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_cast_binary.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_character_test.go

…

handlers_character.go

…

handlers_clients_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_clients.go

…

handlers_commands_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_commands.go

…

handlers_core_test.go

…

handlers_coverage2_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_coverage3_test.go

…

handlers_coverage4_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_coverage5_test.go

…

handlers_coverage_test.go

…

handlers_data_extended_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_data_paper_tables.go

refactor(channelserver): move paper data tables out of handler function

2026-02-23 18:24:54 +01:00

handlers_data_paper_test.go

test(channelserver): add unit tests for paper data handler

2026-02-23 17:01:20 +01:00

handlers_data_paper.go

refactor(channelserver): move paper data tables out of handler function

2026-02-23 18:24:54 +01:00

handlers_data_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_data.go

…

handlers_discord_test.go

…

handlers_discord.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_distitem_test.go

…

handlers_distitem.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_diva_test.go

…

handlers_diva.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_event_test.go

…

handlers_event.go

…

handlers_festa_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_festa.go

…

handlers_gacha_test.go

refactor(gacha): extract gacha logic into GachaService

2026-02-23 23:57:54 +01:00

handlers_gacha.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_goocoo_test.go

…

handlers_goocoo.go

…

handlers_guild_adventure_test.go

…

handlers_guild_adventure.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_guild_alliance_test.go

…

handlers_guild_alliance.go

…

handlers_guild_board_test.go

…

handlers_guild_board.go

…

handlers_guild_cooking_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_guild_cooking.go

…

handlers_guild_icon_test.go

…

handlers_guild_info_test.go

…

handlers_guild_info.go

…

handlers_guild_member_test.go

…

handlers_guild_member.go

…

handlers_guild_mission.go

…

handlers_guild_ops_test.go

refactor(guild): extract disband, resign, leave, and scout logic into GuildService

2026-02-23 23:35:28 +01:00

handlers_guild_ops.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_guild_scout_test.go

refactor(guild): extract disband, resign, leave, and scout logic into GuildService

2026-02-23 23:35:28 +01:00

handlers_guild_scout.go

refactor(guild): extract disband, resign, leave, and scout logic into GuildService

2026-02-23 23:35:28 +01:00

handlers_guild_test.go

…

handlers_guild_tresure_test.go

…

handlers_guild_tresure.go

…

handlers_guild.go

…

handlers_helpers_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_helpers.go

…

handlers_house_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_house.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_items_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_items.go

…

handlers_kouryou_test.go

…

handlers_kouryou.go

…

handlers_mail_test.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

handlers_mail.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

handlers_mercenary_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_mercenary.go

…

handlers_misc_test.go

…

handlers_misc.go

…

handlers_mutex_test.go

…

handlers_mutex.go

…

handlers_object_test.go

…

handlers_object.go

…

handlers_plate_test.go

…

handlers_plate.go

…

handlers_quest_backport_test.go

…

handlers_quest_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_quest.go

…

handlers_register_test.go

…

handlers_register.go

…

handlers_rengoku_integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_rengoku_test.go

…

handlers_rengoku.go

…

handlers_reserve_test.go

…

handlers_reserve.go

…

handlers_reward_test.go

…

handlers_reward.go

…

handlers_savedata_integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_scenario_test.go

…

handlers_scenario.go

…

handlers_seibattle_test.go

…

handlers_seibattle.go

…

handlers_semaphore_test.go

…

handlers_semaphore.go

…

handlers_session_test.go

…

handlers_session.go

feat(pcap): complete replay system with filtering, metadata, and live replay

2026-02-23 19:34:30 +01:00

handlers_shop_gacha_test.go

…

handlers_shop_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_shop.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_simple_test.go

…

handlers_stage_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_stage.go

…

handlers_table.go

…

handlers_tactics_test.go

…

handlers_tactics.go

…

handlers_test.go

…

handlers_tournament_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_tournament.go

…

handlers_tower_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_tower.go

…

handlers_users_test.go

…

handlers_users.go

…

handlers_util_test.go

…

integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

minidata_store_test.go

…

minidata_store.go

…

model_character.go

…

quest_cache_test.go

…

quest_cache.go

…

raviente.go

…

repo_achievement.go

…

repo_cafe.go

…

repo_character_test.go

…

repo_character.go

…

repo_distribution.go

…

repo_diva.go

…

repo_event_test.go

…

repo_event.go

…

repo_festa.go

…

repo_gacha.go

…

repo_goocoo.go

…

repo_guild_adventure.go

…

repo_guild_alliance.go

…

repo_guild_cooking.go

…

repo_guild_hunt.go

…

repo_guild_posts.go

…

repo_guild_rp.go

…

repo_guild_test.go

…

repo_guild.go

…

repo_house.go

…

repo_interfaces.go

…

repo_mail.go

…

repo_mercenary.go

…

repo_misc.go

…

repo_mocks_test.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

repo_rengoku.go

…

repo_scenario.go

…

repo_session.go

…

repo_shop.go

…

repo_stamp.go

…

repo_tower.go

…

repo_user_test.go

…

repo_user.go

…

savedata_lifecycle_monitoring_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

session_lifecycle_integration_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

svc_achievement_test.go

refactor(achievement): extract achievement logic into AchievementService

2026-02-23 23:43:39 +01:00

svc_achievement.go

refactor(achievement): extract achievement logic into AchievementService

2026-02-23 23:43:39 +01:00

svc_gacha_test.go

refactor(gacha): extract gacha logic into GachaService

2026-02-23 23:57:54 +01:00

svc_gacha.go

refactor(gacha): extract gacha logic into GachaService

2026-02-23 23:57:54 +01:00

svc_guild_test.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

svc_guild.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

svc_mail_test.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

svc_mail.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

sys_capture.go

feat(pcap): complete replay system with filtering, metadata, and live replay

2026-02-23 19:34:30 +01:00

sys_channel_server_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_channel_server.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

sys_language_test.go

…

sys_language.go

…

sys_object_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_semaphore_test.go

…

sys_semaphore.go

…

sys_session_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_session.go

feat(pcap): complete replay system with filtering, metadata, and live replay

2026-02-23 19:34:30 +01:00

sys_stage_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

sys_stage.go

…

sys_time.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

test_helpers_test.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

testhelpers_db.go

feat(config): register all defaults in code, shrink example config

2026-02-23 21:25:44 +01:00

user_binary_store_test.go

…

user_binary_store.go

…