Files
Erupe/server/channelserver/handlers_kouryou.go
Houmgaor 458d8c9397 refactor(channelserver): add numeric column helpers and extract protocol constants
Add readCharacterInt/adjustCharacterInt helpers for single-column
integer operations on the characters table. Eliminates fmt.Sprintf
SQL construction in handlers_misc.go and replaces inline queries
across cafe, kouryou, and mercenary handlers.

Second round of protocol constant extraction: adds constants_time.go
(secsPerDay, secsPerWeek), constants_raviente.go (register IDs,
semaphore constants), and named constants across 14 handler files
replacing raw hex/numeric literals. Updates anti-patterns doc to
mark #4 (magic numbers) as substantially fixed.
2026-02-20 21:18:40 +01:00

92 lines
2.6 KiB
Go

package channelserver
import (
"erupe-ce/common/byteframe"
"erupe-ce/network/mhfpacket"
"go.uber.org/zap"
"time"
)
func handleMsgMhfAddKouryouPoint(s *Session, p mhfpacket.MHFPacket) {
// hunting with both ranks maxed gets you these
pkt := p.(*mhfpacket.MsgMhfAddKouryouPoint)
saveStart := time.Now()
s.logger.Debug("Adding Koryo points",
zap.Uint32("charID", s.charID),
zap.Uint32("points_to_add", pkt.KouryouPoints),
)
points, err := adjustCharacterInt(s, "kouryou_point", int(pkt.KouryouPoints))
if err != nil {
s.logger.Error("Failed to update KouryouPoint in db",
zap.Error(err),
zap.Uint32("charID", s.charID),
zap.Uint32("points_to_add", pkt.KouryouPoints),
)
} else {
saveDuration := time.Since(saveStart)
s.logger.Info("Koryo points added successfully",
zap.Uint32("charID", s.charID),
zap.Uint32("points_added", pkt.KouryouPoints),
zap.Int("new_total", points),
zap.Duration("duration", saveDuration),
)
}
resp := byteframe.NewByteFrame()
resp.WriteUint32(uint32(points))
doAckBufSucceed(s, pkt.AckHandle, resp.Data())
}
func handleMsgMhfGetKouryouPoint(s *Session, p mhfpacket.MHFPacket) {
pkt := p.(*mhfpacket.MsgMhfGetKouryouPoint)
points, err := readCharacterInt(s, "kouryou_point")
if err != nil {
s.logger.Error("Failed to get kouryou_point from db",
zap.Error(err),
zap.Uint32("charID", s.charID),
)
} else {
s.logger.Debug("Retrieved Koryo points",
zap.Uint32("charID", s.charID),
zap.Int("points", points),
)
}
resp := byteframe.NewByteFrame()
resp.WriteUint32(uint32(points))
doAckBufSucceed(s, pkt.AckHandle, resp.Data())
}
func handleMsgMhfExchangeKouryouPoint(s *Session, p mhfpacket.MHFPacket) {
// spent at the guildmaster, 10000 a roll
pkt := p.(*mhfpacket.MsgMhfExchangeKouryouPoint)
saveStart := time.Now()
s.logger.Debug("Exchanging Koryo points",
zap.Uint32("charID", s.charID),
zap.Uint32("points_to_spend", pkt.KouryouPoints),
)
points, err := adjustCharacterInt(s, "kouryou_point", -int(pkt.KouryouPoints))
if err != nil {
s.logger.Error("Failed to exchange Koryo points",
zap.Error(err),
zap.Uint32("charID", s.charID),
zap.Uint32("points_to_spend", pkt.KouryouPoints),
)
} else {
saveDuration := time.Since(saveStart)
s.logger.Info("Koryo points exchanged successfully",
zap.Uint32("charID", s.charID),
zap.Uint32("points_spent", pkt.KouryouPoints),
zap.Int("remaining_points", points),
zap.Duration("duration", saveDuration),
)
}
resp := byteframe.NewByteFrame()
resp.WriteUint32(uint32(points))
doAckBufSucceed(s, pkt.AckHandle, resp.Data())
}