Files
Erupe/server/channelserver/repo_achievement.go
Houmgaor 8785ebc21a fix(achievement): fix test failures from migration 0008 side effects
GetAllScores used SELECT * which broke when displayed_levels column was
added — now uses explicit column names. DisplayedAchievement handler
panicked on nil achievementService in empty-handler smoke tests — added
nil guard. Updated msg_build_test.go for renamed tactics point fields.
2026-03-18 12:14:31 +01:00

63 lines
2.7 KiB
Go

package channelserver
import (
"fmt"
"github.com/jmoiron/sqlx"
)
// AchievementRepository centralizes all database access for the achievements table.
type AchievementRepository struct {
db *sqlx.DB
}
// NewAchievementRepository creates a new AchievementRepository.
func NewAchievementRepository(db *sqlx.DB) *AchievementRepository {
return &AchievementRepository{db: db}
}
// EnsureExists creates an achievements record for the character if one doesn't exist.
func (r *AchievementRepository) EnsureExists(charID uint32) error {
_, err := r.db.Exec("INSERT INTO achievements (id) VALUES ($1) ON CONFLICT DO NOTHING", charID)
return err
}
// GetAllScores returns all 33 achievement scores for a character.
func (r *AchievementRepository) GetAllScores(charID uint32) ([33]int32, error) {
var scores [33]int32
err := r.db.QueryRow(`SELECT ach0,ach1,ach2,ach3,ach4,ach5,ach6,ach7,ach8,ach9,
ach10,ach11,ach12,ach13,ach14,ach15,ach16,ach17,ach18,ach19,
ach20,ach21,ach22,ach23,ach24,ach25,ach26,ach27,ach28,ach29,
ach30,ach31,ach32 FROM achievements WHERE id=$1`, charID).Scan(
&scores[0], &scores[1], &scores[2], &scores[3], &scores[4], &scores[5], &scores[6], &scores[7], &scores[8],
&scores[9], &scores[10], &scores[11], &scores[12], &scores[13], &scores[14], &scores[15], &scores[16],
&scores[17], &scores[18], &scores[19], &scores[20], &scores[21], &scores[22], &scores[23], &scores[24],
&scores[25], &scores[26], &scores[27], &scores[28], &scores[29], &scores[30], &scores[31], &scores[32])
return scores, err
}
// IncrementScore increments the score for a specific achievement column.
// achievementID must be in the range [0, 32] to prevent SQL injection.
func (r *AchievementRepository) IncrementScore(charID uint32, achievementID uint8) error {
if achievementID > 32 {
return fmt.Errorf("achievement ID %d out of range [0, 32]", achievementID)
}
_, err := r.db.Exec(fmt.Sprintf("UPDATE achievements SET ach%d=ach%d+1 WHERE id=$1", achievementID, achievementID), charID)
return err
}
// GetDisplayedLevels returns the last-displayed achievement levels for a character.
// Returns nil if never displayed (all rank-ups should trigger notifications).
func (r *AchievementRepository) GetDisplayedLevels(charID uint32) ([]byte, error) {
var levels []byte
err := r.db.QueryRow("SELECT displayed_levels FROM achievements WHERE id=$1", charID).Scan(&levels)
return levels, err
}
// SaveDisplayedLevels stores the current achievement levels as "displayed",
// so future GET_ACHIEVEMENT responses only notify on new rank-ups.
func (r *AchievementRepository) SaveDisplayedLevels(charID uint32, levels []byte) error {
_, err := r.db.Exec("UPDATE achievements SET displayed_levels=$1 WHERE id=$2", levels, charID)
return err
}