Extend setConstCommand "all" (#1884)

* Extend give command "talent"

* Update src/main/java/emu/grasscutter/data/excels/AvatarSkillDepotData.java

Shorten IntStream for getCombatSkills

Co-authored-by: Luke H-W <Birdulon@users.noreply.github.com>

* Fix setSkillLevel to work during avatar construction
Shortening getCombatSkills

* changeSkillLevel now acts as intermediate operation to fetch skillIds

* setSkillLevel changes to allow out of range levels to be normalized

* Update src/main/java/emu/grasscutter/command/commands/GiveCommand.java

Removing recalcStats since it's redundant

Co-authored-by: Luke H-W <Birdulon@users.noreply.github.com>

* Major changes and cleanup:
- AvatarSkillDepotData: removed getCombatSkills since it's unused
- TalentCommand: shortened /talent all using getSkillsAndEnergySkill
- GiveCommand: changed changeSkillLevel to setSkillLevel
- Avatar: delete changeSkillLevel and moved the operation inside setSkillLevel,updated skillId to Integer to catch special cases from GiveCommand

* Small cleanup:
Removed the special case from Avatar to be handled inside of GiveCommand

* Added "all" parameter to SetConst

* Changed all to [all] int SetConstCommand usage

Co-authored-by: Luke H-W <Birdulon@users.noreply.github.com>

Co-authored-by: Luke H-W <Birdulon@users.noreply.github.com>
This commit is contained in:
natsu
2022-10-24 10:58:39 +07:00
committed by GitHub
parent 496cd671da
commit 5b6698f583
11 changed files with 48 additions and 21 deletions

View File

@@ -264,6 +264,7 @@
"fail": "Failed to set constellation.",
"failed_success": "Constellations for %s have been set to %s. Please reload scene to see changes.",
"success": "Constellations for %s have been set to %s.",
"successall": "Constellations for all characters have been set to %s.",
"description": "Sets constellation level for your current active character"
},
"setFetterLevel": {

View File

@@ -264,6 +264,7 @@
"fail": "Error al establecer la constelación.",
"failed_success": "Las constelaciones de %s han sido establecidas a %s. Por favor reinicia el escenario para ver los cambios.",
"success": "Las constelaciones de %s han sido establecidas a %s.",
"successall": "🇺🇸Constellations for all characters have been set to %s.",
"description": "Establece el nivel de constelación para tu personaje actual"
},
"setFetterLevel": {

View File

@@ -264,6 +264,7 @@
"fail": "🇺🇸Failed to set constellation.",
"failed_success": "🇺🇸Constellations for %s have been set to %s. Please reload scene to see changes.",
"success": "🇺🇸Constellations for %s have been set to %s.",
"successall": "🇺🇸Constellations for all characters have been set to %s.",
"description": "🇺🇸Sets constellation level for your current active character"
},
"setFetterLevel": {

View File

@@ -264,6 +264,7 @@
"fail": "星座の設定に失敗しました。",
"failed_success": "%s の星座は %s に設定されました。 シーンをリロードして変更を確認してください。",
"success": "%s の星座は %s に設定されました。",
"successall": "🇺🇸Constellations for all characters have been set to %s.",
"description": "現在アクティブなキャラクターの星座レベルを設定します"
},
"setFetterLevel": {

View File

@@ -264,6 +264,7 @@
"fail": "🇺🇸Failed to set constellation.",
"failed_success": "🇺🇸Constellations for %s have been set to %s. Please reload scene to see changes.",
"success": "🇺🇸Constellations for %s have been set to %s.",
"successall": "🇺🇸Constellations for all characters have been set to %s.",
"description": "🇺🇸Sets constellation level for your current active character"
},
"setFetterLevel": {

View File

@@ -264,6 +264,7 @@
"fail": "Nie udało się ustawić konstelacji.",
"failed_success": "Konstelacje dla %s zostały ustawione na %s. Proszę przeładować scenę aby zobaczyć zmiany.",
"success": "Konstelacje dla %s zostały ustawione na %s.",
"successall": "🇺🇸Constellations for all characters have been set to %s.",
"description": "Ustawia poziom konstelacji dla aktywnej postaci"
},
"setFetterLevel": {

View File

@@ -264,6 +264,7 @@
"fail": "🇺🇸Failed to set constellation.",
"failed_success": "🇺🇸Constellations for %s have been set to %s. Please reload scene to see changes.",
"success": "🇺🇸Constellations for %s have been set to %s.",
"successall": "🇺🇸Constellations for all characters have been set to %s.",
"description": "🇺🇸Sets constellation level for your current active character"
},
"setFetterLevel": {

View File

@@ -264,6 +264,7 @@
"fail": "Не удалось установить уровень созвездия.",
"failed_success": "Созвездия для %s установлены на %s. Перезайдите чтобы изменения вступили в силу.",
"success": "Созвездия для %s были установлены на %s.",
"successall": "🇺🇸Constellations for all characters have been set to %s.",
"description": "Задает уровень созвездия для активного персонажа"
},
"setFetterLevel": {

View File

@@ -264,6 +264,7 @@
"fail": "命之座等级设置失败。",
"failed_success": "命之座 %s 已设置为 %s。",
"success": "命之座 %s 已设置为 %s。",
"successall": "🇺🇸Constellations for all characters have been set to %s.",
"description": "为当前活跃角色设置命座等级"
},
"setFetterLevel": {

View File

@@ -264,6 +264,7 @@
"fail": "設定命座失敗。",
"failed_success": "%s的命之座已設定為成%s重新登入後將會生效。",
"success": "%s的命之座已設定為成%s。",
"successall": "🇺🇸Constellations for all characters have been set to %s.",
"description": "設定當前角色的命之座。"
},
"setFetterLevel": {